[Installer] Remove the CLR Profiler settings from W3SVC #4056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ❄️ New Flaky Tests (2)
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…sary for IIS versions 6 and below, since the WAS was introduced in IIS version 7. Since the minimum version of .NET Framework we support is .NET Framework 4.6.1, and the corresponding minimum OS version is Windows Server 2008 R2 SP1, we will only encounter IIS 7+, so we can always rely on the WAS for our environment variables. Resources: - https://techcommunity.microsoft.com/t5/iis-support-blog/iis-services-http-sys-w3svc-was-w3wp-oh-my/ba-p/287856 - https://learn.microsoft.com/en-us/iis/manage/provisioning-and-managing-iis/features-of-the-windows-process-activation-service-was - https://learn.microsoft.com/en-us/lifecycle/products/internet-information-services-iis - https://learn.microsoft.com/en-us/dotnet/framework/migration-guide/versions-and-dependencies#net-framework-461 -
zacharycmontoya
force-pushed
the
zach/iis-environment-variables
branch
from
644b9dd to
2dcb6cb
Compare
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (3,019ms) : 2886, 3151
. : milestone, 3019,
master - mean (3,015ms) : 2891, 3139
. : milestone, 3015,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (3,665ms) : 3588, 3742
. : milestone, 3665,
master - mean (3,683ms) : 3609, 3757
. : milestone, 3683,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (3,145ms) : 3012, 3278
. : milestone, 3145,
master - mean (3,122ms) : 3008, 3235
. : milestone, 3122,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (3,551ms) : 3441, 3660
. : milestone, 3551,
master - mean (3,530ms) : 3432, 3628
. : milestone, 3530,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (3,113ms) : 3014, 3212
. : milestone, 3113,
master - mean (3,100ms) : 2964, 3236
. : milestone, 3100,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (3,521ms) : 3440, 3602
. : milestone, 3521,
master - mean (3,511ms) : 3435, 3587
. : milestone, 3511,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (188ms) : 183, 193
. : milestone, 188,
master - mean (188ms) : 184, 191
. : milestone, 188,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (941ms) : 906, 975
. : milestone, 941,
master - mean (940ms) : 918, 963
. : milestone, 940,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (368ms) : 361, 374
. : milestone, 368,
master - mean (368ms) : 363, 373
. : milestone, 368,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (1,090ms) : 1060, 1119
. : milestone, 1090,
master - mean (1,089ms) : 1063, 1115
. : milestone, 1089,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (4056) - mean (356ms) : 349, 364
. : milestone, 356,
master - mean (357ms) : 353, 362
. : milestone, 357,
section CallTarget+Inlining+NGEN
This PR (4056) - mean (1,036ms) : 1010, 1062
. : milestone, 1036,
master - mean (1,042ms) : 1017, 1068
. : milestone, 1042,
|
Benchmarks Report 🐌Benchmarks for #4056 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
andrewlock
approved these changes
Apr 24, 2023
pierotibou
approved these changes
Apr 26, 2023
| @@ -21,14 +21,6 @@ | |||
| </ComponentGroup> | |||
|
|
|||
| <ComponentGroup Id="Shared.EnvironmentVariables.IIS" Directory="INSTALLFOLDER"> | |||
| <Component Id="Shared.Registry.EnvironmentVariables.W3SVC" Guid="{702DB265-F33E-47F4-A6B0-E21FA0FC21C1}" Win64="$(var.Win64)"> | |||
| <CreateFolder/> | |||
There was a problem hiding this comment.
What does createFolder does here? It creates the group in the registry for Shared.Registry.EnvironmentVariables.W3SVC if it didn't exist? Just to be sure I understand what I'm approving? (I looked at the documentation but I'm not sure so I'd rather ask)
lucaspimentel
approved these changes
Apr 28, 2023
zacharycmontoya
added
the
status:do-not-merge
|
Revisiting this PR, I'd still like to move forward with this change, but I'd also like to verify with telemetry that we're not running on these systems. I've added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Removes the installer directive that adds the CLR Profiler settings to the W3SVC service
Reason for change
Previously, we were setting the CLR Profiler settings in both the WAS and the W3SVC. We had to set the W3SVC service to cover IIS versions 6 and below, since the WAS was introduced in IIS version 7, but this is no longer needed. Now that the minimum version of .NET Framework that we support is .NET Framework 4.6.1, and the corresponding minimum OS version is Windows Server 2008 R2 SP1, we will only encounter IIS 7+.
Resources:
Implementation details
Removes the lines.
Test coverage
Existing integration tests and smoke tests should pass
Other details
N/A