Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Disable shared clock on version conflict #4459

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Disable shared clock on version conflict #4459

wants to merge 1 commit into from

Conversation

tonyredondo
Copy link
Member

@tonyredondo tonyredondo commented Jul 27, 2023 •
edited
Loading

Summary of changes

This PR disabled the shared clock across multiple traces instances when a version conflict is detected.

Reason for change

See #4450, this is not a complete fix for the issue, but reduces the frequency of happening due to the (15ms) precision of the UtcNow.

For a complete fix we should create a ITraceClock interface and share it between the tracers, this can be done in a new IAutomaticTracer2, IManualTracer2 initiative.

@tonyredondo tonyredondo requested a review from a team as a code owner July 27, 2023 17:03
@tonyredondo tonyredondo self-assigned this Jul 27, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jul 27, 2023 •
edited
Loading

Datadog Report

Branch report: tony/disable-shared-clock-on-version-conflict
Commit report: 3b91939

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 294344 Passed, 1091 Skipped, 34m 27.79s Wall Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (3,028ms)  : 2966, 3089
     .   : milestone, 3028,
    master - mean (3,013ms)  : 2909, 3117
     .   : milestone, 3013,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (3,837ms)  : 3722, 3952
     .   : milestone, 3837,
    master - mean (3,829ms)  : 3755, 3903
     .   : milestone, 3829,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (3,138ms)  : 3030, 3246
     .   : milestone, 3138,
    master - mean (3,126ms)  : 3003, 3250
     .   : milestone, 3126,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (3,615ms)  : 3532, 3697
     .   : milestone, 3615,
    master - mean (3,608ms)  : 3564, 3653
     .   : milestone, 3608,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (3,110ms)  : 2987, 3234
     .   : milestone, 3110,
    master - mean (3,096ms)  : 2995, 3197
     .   : milestone, 3096,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (3,584ms)  : 3509, 3660
     .   : milestone, 3584,
    master - mean (3,583ms)  : 3521, 3644
     .   : milestone, 3583,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (192ms)  : 186, 197
     .   : milestone, 192,
    master - mean (191ms)  : 188, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (1,124ms)  : 1097, 1151
     .   : milestone, 1124,
    master - mean (1,123ms)  : 1097, 1149
     .   : milestone, 1123,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (380ms)  : 370, 389
     .   : milestone, 380,
    master - mean (372ms)  : 367, 378
     .   : milestone, 372,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (1,180ms)  : 1150, 1210
     .   : milestone, 1180,
    master - mean (1,175ms)  : 1159, 1191
     .   : milestone, 1175,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4459) - mean (364ms)  : 358, 370
     .   : milestone, 364,
    master - mean (360ms)  : 357, 363
     .   : milestone, 360,

    section CallTarget+Inlining+NGEN
    This PR (4459) - mean (1,140ms)  : 1112, 1168
     .   : milestone, 1140,
    master - mean (1,127ms)  : 1099, 1154
     .   : milestone, 1127,

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4459 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.201
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 498μs 129ns 467ns 0 0 0 2.62 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 274ns 1.06μs 0 0 0 2.63 KB
master WriteAndFlushEnrichedTraces net472 791μs 574ns 2.15μs 0.396 0 0 3.22 KB
#4459 WriteAndFlushEnrichedTraces net6.0 481μs 708ns 2.74μs 0 0 0 2.62 KB
#4459 WriteAndFlushEnrichedTraces netcoreapp3.1 643μs 1.52μs 5.9μs 0 0 0 2.63 KB
#4459 WriteAndFlushEnrichedTraces net472 797μs 447ns 1.67μs 0.396 0 0 3.22 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 39.3μs 31.5ns 122ns 0.0191 0 0 1.65 KB
master AllCycleSimpleBody netcoreapp3.1 40.2μs 133ns 514ns 0 0 0 1.63 KB
master AllCycleSimpleBody net472 41.2μs 191ns 741ns 0.264 0 0 1.69 KB
master AllCycleMoreComplexBody net6.0 223μs 209ns 810ns 0.111 0 0 9.22 KB
master AllCycleMoreComplexBody netcoreapp3.1 230μs 341ns 1.32μs 0.115 0 0 9.12 KB
master AllCycleMoreComplexBody net472 236μs 53.9ns 202ns 1.42 0 0 9.28 KB
master ObjectExtractorSimpleBody net6.0 119ns 0.0548ns 0.212ns 0.00392 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 180ns 0.0862ns 0.311ns 0.0037 0 0 272 B
master ObjectExtractorSimpleBody net472 147ns 0.102ns 0.394ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.9μs 0.96ns 3.59ns 0.0538 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.07μs 1.44ns 5.58ns 0.0505 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.02μs 2.06ns 7.97ns 0.617 0.00603 0 3.89 KB
#4459 AllCycleSimpleBody net6.0 38.6μs 42.3ns 153ns 0.0194 0 0 1.65 KB
#4459 AllCycleSimpleBody netcoreapp3.1 40.7μs 66.1ns 256ns 0.0205 0 0 1.63 KB
#4459 AllCycleSimpleBody net472 41.1μs 18.9ns 68.2ns 0.266 0 0 1.69 KB
#4459 AllCycleMoreComplexBody net6.0 223μs 107ns 399ns 0.111 0 0 9.22 KB
#4459 AllCycleMoreComplexBody netcoreapp3.1 230μs 317ns 1.19μs 0.115 0 0 9.12 KB
#4459 AllCycleMoreComplexBody net472 237μs 151ns 583ns 1.42 0 0 9.28 KB
#4459 ObjectExtractorSimpleBody net6.0 119ns 0.0724ns 0.28ns 0.00392 0 0 280 B
#4459 ObjectExtractorSimpleBody netcoreapp3.1 173ns 0.128ns 0.497ns 0.00363 0 0 272 B
#4459 ObjectExtractorSimpleBody net472 147ns 0.247ns 0.956ns 0.0446 0 0 281 B
#4459 ObjectExtractorMoreComplexBody net6.0 2.97μs 0.941ns 3.52ns 0.0535 0 0 3.88 KB
#4459 ObjectExtractorMoreComplexBody netcoreapp3.1 4.02μs 1.29ns 4.85ns 0.0522 0 0 3.78 KB
#4459 ObjectExtractorMoreComplexBody net472 4.02μs 1.91ns 7.16ns 0.618 0.006 0 3.89 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 168μs 183ns 709ns 0.168 0 0 18.08 KB
master SendRequest netcoreapp3.1 191μs 495ns 1.92μs 0.191 0 0 20.14 KB
master SendRequest net472 9.74E‑05ns 6.2E‑05ns 0.000232ns 0 0 0 0 b
#4459 SendRequest net6.0 170μs 167ns 624ns 0.171 0 0 18.08 KB
#4459 SendRequest netcoreapp3.1 188μs 330ns 1.28μs 0.189 0 0 20.14 KB
#4459 SendRequest net472 0.00113ns 0.000371ns 0.00144ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 525μs 603ns 2.33μs 0.506 0 0 41.68 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 628μs 709ns 2.75μs 0.311 0 0 41.65 KB
master WriteAndFlushEnrichedTraces net472 784μs 3.98μs 17.4μs 8.1 2.31 0.386 53.33 KB
#4459 WriteAndFlushEnrichedTraces net6.0 513μs 284ns 1.02μs 0.514 0 0 41.63 KB
#4459 WriteAndFlushEnrichedTraces netcoreapp3.1 628μs 1.4μs 5.04μs 0.312 0 0 41.84 KB
#4459 WriteAndFlushEnrichedTraces net472 771μs 3.23μs 12.5μs 8.1 2.31 0.386 53.22 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 953ns 0.273ns 1.06ns 0.0105 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.19μs 0.372ns 1.39ns 0.0102 0 0 768 B
master ExecuteNonQuery net472 1.41μs 0.596ns 2.23ns 0.115 0 0 730 B
#4459 ExecuteNonQuery net6.0 957ns 0.286ns 1.11ns 0.0105 0 0 768 B
#4459 ExecuteNonQuery netcoreapp3.1 1.16μs 0.615ns 2.38ns 0.0105 0 0 768 B
#4459 ExecuteNonQuery net472 1.41μs 0.611ns 2.37ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.09μs 0.371ns 1.44ns 0.0138 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.31μs 0.504ns 1.95ns 0.0132 0 0 992 B
master CallElasticsearch net472 2.09μs 0.955ns 3.7ns 0.159 0.00105 0 1 KB
master CallElasticsearchAsync net6.0 1.1μs 0.398ns 1.49ns 0.0133 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.44μs 4ns 15.5ns 0.0136 0 0 1.04 KB
master CallElasticsearchAsync net472 2.27μs 0.77ns 2.88ns 0.168 0.00113 0 1.06 KB
#4459 CallElasticsearch net6.0 1.04μs 0.287ns 1.07ns 0.0136 0 0 992 B
#4459 CallElasticsearch netcoreapp3.1 1.36μs 0.586ns 2.19ns 0.0136 0 0 992 B
#4459 CallElasticsearch net472 2.16μs 0.528ns 2.04ns 0.159 0.00108 0 1 KB
#4459 CallElasticsearchAsync net6.0 1.17μs 0.463ns 1.73ns 0.0134 0 0 968 B
#4459 CallElasticsearchAsync netcoreapp3.1 1.44μs 0.569ns 2.05ns 0.0137 0 0 1.04 KB
#4459 CallElasticsearchAsync net472 2.27μs 0.475ns 1.84ns 0.168 0.00114 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.07μs 0.343ns 1.28ns 0.0128 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.35μs 0.461ns 1.78ns 0.0122 0 0 912 B
master ExecuteAsync net472 1.48μs 0.416ns 1.55ns 0.139 0.000739 0 875 B
#4459 ExecuteAsync net6.0 1.03μs 0.404ns 1.56ns 0.0125 0 0 912 B
#4459 ExecuteAsync netcoreapp3.1 1.33μs 0.797ns 3.09ns 0.0118 0 0 912 B
#4459 ExecuteAsync net472 1.47μs 0.309ns 1.2ns 0.138 0.000732 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.39μs 0.962ns 3.73ns 0.027 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.28μs 1.23ns 4.43ns 0.0322 0 0 2.48 KB
master SendAsync net472 6.93μs 3.45ns 12.9ns 0.482 0 0 3.05 KB
#4459 SendAsync net6.0 3.56μs 1.19ns 4.6ns 0.0268 0 0 1.94 KB
#4459 SendAsync netcoreapp3.1 4.32μs 1.49ns 5.59ns 0.0346 0 0 2.48 KB
#4459 SendAsync net472 6.99μs 3.09ns 11.6ns 0.482 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.37μs 1.32ns 5.11ns 0.0226 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.8μs 0.817ns 3.06ns 0.0216 0 0 1.62 KB
master EnrichedLog net472 2.28μs 0.974ns 3.65ns 0.244 0 0 1.54 KB
#4459 EnrichedLog net6.0 1.3μs 0.768ns 2.87ns 0.0228 0 0 1.62 KB
#4459 EnrichedLog netcoreapp3.1 1.97μs 0.638ns 2.3ns 0.0218 0 0 1.62 KB
#4459 EnrichedLog net472 2.25μs 2.6ns 9.71ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 111μs 74.8ns 259ns 0.0555 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 117μs 175ns 677ns 0.0585 0 0 4.21 KB
master EnrichedLog net472 147μs 211ns 819ns 0.662 0.221 0 4.38 KB
#4459 EnrichedLog net6.0 113μs 145ns 563ns 0.0561 0 0 4.21 KB
#4459 EnrichedLog netcoreapp3.1 117μs 81.2ns 281ns 0.0582 0 0 4.21 KB
#4459 EnrichedLog net472 146μs 50.7ns 196ns 0.655 0.218 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.77μs 1.21ns 4.52ns 0.0304 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.9μs 11.3ns 40.7ns 0.0289 0 0 2.18 KB
master EnrichedLog net472 4.57μs 0.805ns 3.01ns 0.315 0 0 1.99 KB
#4459 EnrichedLog net6.0 2.86μs 1.01ns 3.79ns 0.0301 0 0 2.18 KB
#4459 EnrichedLog netcoreapp3.1 3.8μs 1.97ns 7.61ns 0.0301 0 0 2.18 KB
#4459 EnrichedLog net472 4.55μs 1.8ns 6.96ns 0.316 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.21μs 0.573ns 2.22ns 0.0164 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.43μs 0.661ns 2.38ns 0.0163 0 0 1.16 KB
master SendReceive net472 1.73μs 0.819ns 3.07ns 0.185 0 0 1.16 KB
#4459 SendReceive net6.0 1.32μs 0.605ns 2.18ns 0.0164 0 0 1.16 KB
#4459 SendReceive netcoreapp3.1 1.47μs 0.567ns 2.2ns 0.0155 0 0 1.16 KB
#4459 SendReceive net472 1.83μs 1.89ns 7.32ns 0.185 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.5μs 0.918ns 3.56ns 0.0212 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.6μs 1.07ns 3.87ns 0.0198 0 0 1.58 KB
master EnrichedLog net472 3.96μs 1.69ns 6.54ns 0.31 0 0 1.96 KB
#4459 EnrichedLog net6.0 2.57μs 0.604ns 2.26ns 0.0205 0 0 1.53 KB
#4459 EnrichedLog netcoreapp3.1 3.75μs 0.779ns 2.81ns 0.0206 0 0 1.58 KB
#4459 EnrichedLog net472 4.01μs 1.04ns 3.62ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4459

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.354 371.46 503.05
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.149 450.42 517.64
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.113 718.03 799.25

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 372ns 0.179ns 0.622ns 0.0076 0 0 536 B
master StartFinishSpan netcoreapp3.1 509ns 0.228ns 0.855ns 0.00709 0 0 536 B
master StartFinishSpan net472 549ns 0.129ns 0.481ns 0.0853 0 0 538 B
master StartFinishScope net6.0 450ns 0.0998ns 0.373ns 0.0091 0 0 656 B
master StartFinishScope netcoreapp3.1 718ns 0.343ns 1.33ns 0.00881 0 0 656 B
master StartFinishScope net472 751ns 0.16ns 0.597ns 0.0979 0 0 618 B
#4459 StartFinishSpan net6.0 503ns 0.151ns 0.566ns 0.0075 0 0 536 B
#4459 StartFinishSpan netcoreapp3.1 505ns 0.27ns 1.01ns 0.00736 0 0 536 B
#4459 StartFinishSpan net472 602ns 0.127ns 0.459ns 0.0854 0 0 538 B
#4459 StartFinishScope net6.0 518ns 0.205ns 0.793ns 0.00922 0 0 656 B
#4459 StartFinishScope netcoreapp3.1 799ns 0.403ns 1.51ns 0.00888 0 0 656 B
#4459 StartFinishScope net472 806ns 0.275ns 1.03ns 0.098 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 554ns 0.143ns 0.535ns 0.00916 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 786ns 0.352ns 1.32ns 0.00873 0 0 656 B
master RunOnMethodBegin net472 916ns 0.343ns 1.28ns 0.0979 0 0 618 B
#4459 RunOnMethodBegin net6.0 615ns 0.209ns 0.78ns 0.00909 0 0 656 B
#4459 RunOnMethodBegin netcoreapp3.1 791ns 1.5ns 5.8ns 0.00906 0 0 656 B
#4459 RunOnMethodBegin net472 934ns 0.17ns 0.658ns 0.098 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
Loading 
gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4459) (11.211M)   : 0, 11211012
    master (10.877M)   : 0, 10877040
    benchmarks/2.34.0 (11.172M)   : 0, 11172386
    benchmarks/2.9.0 (11.226M)   : 0, 11225900

    section Automatic
    This PR (4459) (7.843M)   : 0, 7842583
    master (7.669M)   : 0, 7669221
    benchmarks/2.34.0 (7.859M)   : 0, 7858718
    benchmarks/2.9.0 (8.128M)   : 0, 8127670

    section Trace stats
    master (7.809M)   : 0, 7808796
    benchmarks/2.34.0 (7.905M)   : 0, 7904802

    section Manual
    This PR (4459) (9.990M)   : 0, 9990303
    master (9.823M)   : 0, 9822723
    benchmarks/2.34.0 (9.986M)   : 0, 9986137

    section Manual + Automatic
    This PR (4459) (7.542M)   : 0, 7542458
    master (7.406M)   : 0, 7405833
    benchmarks/2.34.0 (7.570M)   : 0, 7570487

    section Version Conflict
    master (6.770M)   : 0, 6769692
    benchmarks/2.34.0 (6.749M)   : 0, 6749094
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4459) (9.688M)   : 0, 9688320
    master (9.574M)   : 0, 9574337
    benchmarks/2.34.0 (9.689M)   : 0, 9689253
    benchmarks/2.9.0 (9.659M)   : 0, 9658728

    section Automatic
    This PR (4459) (6.679M)   : 0, 6679458
    master (6.813M)   : 0, 6812599
    benchmarks/2.34.0 (6.670M)   : 0, 6670396

    section Trace stats
    master (6.818M)   : 0, 6817725
    benchmarks/2.34.0 (6.743M)   : 0, 6743225

    section Manual
    This PR (4459) (8.533M)   : 0, 8532615
    master (8.437M)   : 0, 8437210
    benchmarks/2.34.0 (8.614M)   : 0, 8614349

    section Manual + Automatic
    This PR (4459) (6.542M)   : 0, 6541500
    master (6.566M)   : 0, 6566202
    benchmarks/2.34.0 (6.532M)   : 0, 6532340

    section Version Conflict
    master (5.892M)   : 0, 5892214
    benchmarks/2.34.0 (5.854M)   : 0, 5853936
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4459) (10.227M)   : 0, 10226916
    master (10.238M)   : 0, 10238267
    benchmarks/2.34.0 (10.187M)   : 0, 10187020
    benchmarks/2.9.0 (10.240M)   : 0, 10239951

    section Automatic
    This PR (4459) (7.479M)   : 0, 7478741
    master (7.591M)   : 0, 7591432
    benchmarks/2.34.0 (7.402M)   : 0, 7401872
    benchmarks/2.9.0 (7.435M)   : 0, 7435116

    section Trace stats
    master (7.326M)   : 0, 7326243
    benchmarks/2.34.0 (7.426M)   : 0, 7426314

    section Manual
    This PR (4459) (9.208M)   : 0, 9207993
    master (9.424M)   : 0, 9423734
    benchmarks/2.34.0 (9.173M)   : 0, 9173438

    section Manual + Automatic
    This PR (4459) (7.196M)   : 0, 7195627
    master (7.437M)   : 0, 7437421
    benchmarks/2.34.0 (7.218M)   : 0, 7218183

    section Version Conflict
    master (6.561M)   : 0, 6561453
    benchmarks/2.34.0 (6.597M)   : 0, 6597265
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4459) (7.319M)   : 0, 7319272
    master (7.353M)   : 0, 7353218
    benchmarks/2.34.0 (7.612M)   : 0, 7611651
    benchmarks/2.9.0 (7.840M)   : 0, 7839825

    section No attack
    This PR (4459) (2.089M)   : 0, 2089171
    master (2.138M)   : 0, 2137647
    benchmarks/2.34.0 (2.156M)   : 0, 2156076
    benchmarks/2.9.0 (3.181M)   : 0, 3180750

    section Attack
    This PR (4459) (1.812M)   : 0, 1812053
    master (1.816M)   : 0, 1816342
    benchmarks/2.9.0 (2.474M)   : 0, 2474287

    section Blocking
    This PR (4459) (3.676M)   : 0, 3675527
    master (3.656M)   : 0, 3655676

@tonyredondo tonyredondo mentioned this pull request Jul 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tonyredondo tonyredondo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyredondo @andrewlock