Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tony/autoinstrumentation-generator-open-nuget #4651

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

tony/autoinstrumentation-generator-open-nuget #4651

wants to merge 1 commit into from

Conversation

tonyredondo
Copy link
Member

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@tonyredondo tonyredondo self-assigned this Sep 25, 2023
@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Sep 25, 2023 •
edited
Loading

Datadog Report

Branch report: tony/autoinstrumentation-generator-open-nuget
Commit report: e79a120

❌ dd-trace-dotnet: 1 Failed (0 Known Flaky), 0 New Flaky, 302668 Passed, 1146 Skipped, 22m 44.52s Wall Time

❌ Failed Tests (1)

  • IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.TraceAnnotationsAutomaticOnlyTests - Details

    Expand for error 
     Expected varintegration=latestIntegrations {["WebRequest"] = IntegrationTelemetryData { Name = WebRequest, Enabled = False, AutoEnabled = True, Error =  }} to contain key "TraceAnnotations".

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (69ms)  : 63, 75
     .   : milestone, 69,
    master - mean (71ms)  : 61, 82
     .   : milestone, 71,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (1,039ms)  : 1011, 1068
     .   : milestone, 1039,
    master - mean (1,040ms)  : 1009, 1070
     .   : milestone, 1040,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (105ms)  : 103, 108
     .   : milestone, 105,
    master - mean (105ms)  : 102, 109
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (750ms)  : 733, 768
     .   : milestone, 750,
    master - mean (747ms)  : 723, 772
     .   : milestone, 747,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (90ms)  : 86, 94
     .   : milestone, 90,
    master - mean (90ms)  : 86, 94
     .   : milestone, 90,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (708ms)  : 686, 730
     .   : milestone, 708,
    master - mean (712ms)  : 697, 727
     .   : milestone, 712,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (188ms)  : 178, 197
     .   : milestone, 188,
    master - mean (185ms)  : 179, 192
     .   : milestone, 185,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (1,139ms)  : 1112, 1165
     .   : milestone, 1139,
    master - mean (1,116ms)  : 1088, 1144
     .   : milestone, 1116,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (275ms)  : 269, 281
     .   : milestone, 275,
    master - mean (265ms)  : 254, 276
     .   : milestone, 265,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (1,108ms)  : 1071, 1146
     .   : milestone, 1108,
    master - mean (1,069ms)  : 1035, 1104
     .   : milestone, 1069,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4651) - mean (270ms)  : 262, 277
     .   : milestone, 270,
    master - mean (256ms)  : 245, 266
     .   : milestone, 256,

    section CallTarget+Inlining+NGEN
    This PR (4651) - mean (1,060ms)  : 1025, 1094
     .   : milestone, 1060,
    master - mean (1,027ms)  : 990, 1064
     .   : milestone, 1027,

@andrewlock
Copy link
Member

Benchmarks Report 🐌

Benchmarks for #4651 compared to master:

  • 3 benchmarks are slower, with geometric mean 1.179
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.1μs 38.1ns 183ns 0.02 0.00799 0 7.29 KB
master StartStopWithChild netcoreapp3.1 10μs 53.3ns 261ns 0.0309 0.0154 0 7.38 KB
master StartStopWithChild net472 15.5μs 38.1ns 147ns 1.28 0.319 0.106 7.65 KB
#4651 StartStopWithChild net6.0 8.16μs 44.3ns 266ns 0.024 0.012 0 7.29 KB
#4651 StartStopWithChild netcoreapp3.1 10μs 42.8ns 176ns 0.0245 0.00979 0 7.38 KB
#4651 StartStopWithChild net472 15.7μs 32ns 120ns 1.28 0.313 0.102 7.67 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 480μs 323ns 1.25μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 662μs 238ns 858ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 804μs 221ns 855ns 0.401 0 0 3.3 KB
#4651 WriteAndFlushEnrichedTraces net6.0 472μs 142ns 510ns 0 0 0 2.7 KB
#4651 WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 231ns 895ns 0 0 0 2.7 KB
#4651 WriteAndFlushEnrichedTraces net472 809μs 345ns 1.34μs 0.403 0 0 3.3 KB
Benchmarks.Trace.Asm.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4651

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody‑netcoreapp3.1 1.176 176.84 207.95

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net6.0 44.6μs 205ns 738ns 0.0215 0 0 2.03 KB
master AllCycleSimpleBody netcoreapp3.1 44.8μs 32.2ns 120ns 0.0225 0 0 2.01 KB
master AllCycleSimpleBody net472 46μs 93.6ns 362ns 0.319 0 0 2.08 KB
master AllCycleMoreComplexBody net6.0 229μs 164ns 636ns 0.114 0 0 8.63 KB
master AllCycleMoreComplexBody netcoreapp3.1 235μs 95.2ns 369ns 0 0 0 8.52 KB
master AllCycleMoreComplexBody net472 237μs 92.9ns 360ns 1.3 0 0 8.7 KB
master ObjectExtractorSimpleBody net6.0 124ns 0.112ns 0.434ns 0.00396 0 0 280 B
master ObjectExtractorSimpleBody netcoreapp3.1 177ns 0.0716ns 0.258ns 0.00369 0 0 272 B
master ObjectExtractorSimpleBody net472 147ns 0.105ns 0.392ns 0.0446 0 0 281 B
master ObjectExtractorMoreComplexBody net6.0 2.99μs 0.957ns 3.71ns 0.0541 0 0 3.88 KB
master ObjectExtractorMoreComplexBody netcoreapp3.1 4.03μs 2.29ns 8.58ns 0.0504 0 0 3.78 KB
master ObjectExtractorMoreComplexBody net472 4.11μs 2.41ns 9.35ns 0.618 0.00614 0 3.89 KB
#4651 AllCycleSimpleBody net6.0 44.1μs 58.2ns 225ns 0.0222 0 0 2.03 KB
#4651 AllCycleSimpleBody netcoreapp3.1 45.2μs 92.1ns 357ns 0.0228 0 0 2.01 KB
#4651 AllCycleSimpleBody net472 47μs 49.7ns 192ns 0.324 0 0 2.08 KB
#4651 AllCycleMoreComplexBody net6.0 230μs 89.4ns 346ns 0.115 0 0 8.63 KB
#4651 AllCycleMoreComplexBody netcoreapp3.1 235μs 98.2ns 367ns 0.117 0 0 8.52 KB
#4651 AllCycleMoreComplexBody net472 239μs 116ns 449ns 1.31 0 0 8.7 KB
#4651 ObjectExtractorSimpleBody net6.0 118ns 0.0252ns 0.0944ns 0.00393 0 0 280 B
#4651 ObjectExtractorSimpleBody netcoreapp3.1 208ns 0.142ns 0.548ns 0.00373 0 0 272 B
#4651 ObjectExtractorSimpleBody net472 144ns 0.103ns 0.399ns 0.0446 0 0 281 B
#4651 ObjectExtractorMoreComplexBody net6.0 3.07μs 1.21ns 4.7ns 0.0538 0 0 3.88 KB
#4651 ObjectExtractorMoreComplexBody netcoreapp3.1 4.12μs 2.52ns 9.74ns 0.0515 0 0 3.78 KB
#4651 ObjectExtractorMoreComplexBody net472 4.08μs 2.69ns 10.4ns 0.617 0.00613 0 3.89 KB
Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunWaf(args=NestedMap (10)) net6.0 12.7μs 6.34ns 23.7ns 0.128 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) netcoreapp3.1 19.8μs 5.63ns 20.3ns 0.129 0 0 9.42 KB
master RunWaf(args=NestedMap (10)) net472 28.7μs 6.93ns 26.8ns 1.5 0 0 9.48 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 76.5μs 38.1ns 148ns 0.191 0 0 15.77 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 85.3μs 147ns 570ns 0.213 0 0 15.72 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 97.8μs 248ns 962ns 2.52 0 0 16.04 KB
master RunWaf(args=NestedMap (100)) net6.0 24.5μs 13ns 48.5ns 0.27 0 0 19.66 KB
master RunWaf(args=NestedMap (100)) netcoreapp3.1 37.6μs 11.8ns 42.6ns 0.264 0 0 20.42 KB
master RunWaf(args=NestedMap (100)) net472 53.7μs 19ns 71ns 3.27 0.0268 0 20.63 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 95.2μs 24.7ns 95.6ns 0.331 0 0 26.01 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 110μs 231ns 864ns 0.328 0 0 26.72 KB
master RunWafWithAttack(args=Neste(...)tack) [23]) net472 129μs 84.4ns 316ns 4.27 0.0647 0 27.19 KB
master RunWaf(args=NestedMap (20)) net6.0 23.7μs 9.4ns 36.4ns 0.271 0 0 19.4 KB
master RunWaf(args=NestedMap (20)) netcoreapp3.1 37.5μs 18.8ns 70.3ns 0.263 0 0 19.84 KB
master RunWaf(args=NestedMap (20)) net472 54.6μs 27.4ns 106ns 3.17 0.0546 0 20.04 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 91.1μs 43.4ns 162ns 0.32 0 0 25.74 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 108μs 211ns 819ns 0.324 0 0 26.14 KB
master RunWafWithAttack(args=Neste(...)tack) [22]) net472 131μs 91.5ns 355ns 4.22 0.065 0 26.6 KB
#4651 RunWaf(args=NestedMap (10)) net6.0 12.8μs 4.17ns 15.1ns 0.133 0 0 9.42 KB
#4651 RunWaf(args=NestedMap (10)) netcoreapp3.1 19.2μs 4.31ns 16.7ns 0.124 0 0 9.42 KB
#4651 RunWaf(args=NestedMap (10)) net472 28.1μs 17.5ns 65.5ns 1.5 0 0 9.48 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 77.4μs 114ns 427ns 0.193 0 0 15.77 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 87.2μs 334ns 1.29μs 0.218 0 0 15.72 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) net472 97.1μs 223ns 834ns 2.54 0 0 16.04 KB
#4651 RunWaf(args=NestedMap (100)) net6.0 24.5μs 8.52ns 31.9ns 0.279 0 0 19.66 KB
#4651 RunWaf(args=NestedMap (100)) netcoreapp3.1 37.7μs 10.1ns 37.7ns 0.282 0 0 20.42 KB
#4651 RunWaf(args=NestedMap (100)) net472 55μs 22ns 82.1ns 3.26 0.0276 0 20.63 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [23]) net6.0 94.7μs 181ns 699ns 0.331 0 0 26.01 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [23]) netcoreapp3.1 109μs 224ns 839ns 0.325 0 0 26.72 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [23]) net472 130μs 215ns 832ns 4.26 0.0646 0 27.19 KB
#4651 RunWaf(args=NestedMap (20)) net6.0 23.5μs 7.37ns 27.6ns 0.272 0 0 19.4 KB
#4651 RunWaf(args=NestedMap (20)) netcoreapp3.1 37.7μs 28.2ns 105ns 0.263 0 0 19.84 KB
#4651 RunWaf(args=NestedMap (20)) net472 53.5μs 20.5ns 79.2ns 3.16 0.0536 0 20.04 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) net6.0 94.3μs 39.5ns 148ns 0.329 0 0 25.74 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) netcoreapp3.1 108μs 223ns 833ns 0.321 0 0 26.14 KB
#4651 RunWafWithAttack(args=Neste(...)tack) [22]) net472 132μs 54.4ns 211ns 4.21 0.0658 0 26.6 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 170μs 154ns 596ns 0.254 0 0 18.09 KB
master SendRequest netcoreapp3.1 191μs 118ns 424ns 0.192 0 0 20.25 KB
master SendRequest net472 0.000191ns 0.000154ns 0.000598ns 0 0 0 0 b
#4651 SendRequest net6.0 168μs 176ns 680ns 0.167 0 0 18.09 KB
#4651 SendRequest netcoreapp3.1 190μs 481ns 1.86μs 0.189 0 0 20.25 KB
#4651 SendRequest net472 0.000907ns 0.000407ns 0.00158ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 506μs 596ns 2.23μs 0.772 0 0 41.42 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 616μs 979ns 3.66μs 0.305 0 0 41.84 KB
master WriteAndFlushEnrichedTraces net472 780μs 2.98μs 11.6μs 8.38 2.67 0.381 53.23 KB
#4651 WriteAndFlushEnrichedTraces net6.0 501μs 2.39μs 9.56μs 0.519 0 0 41.4 KB
#4651 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 1.33μs 5.17μs 0.316 0 0 41.64 KB
#4651 WriteAndFlushEnrichedTraces net472 814μs 3.67μs 13.7μs 8.41 2.4 0.401 53.24 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.09μs 0.903ns 3.5ns 0.0109 0 0 768 B
master ExecuteNonQuery netcoreapp3.1 1.34μs 0.837ns 3.24ns 0.0102 0 0 768 B
master ExecuteNonQuery net472 1.56μs 2.25ns 8.11ns 0.116 0 0 730 B
#4651 ExecuteNonQuery net6.0 1.11μs 0.426ns 1.65ns 0.0105 0 0 768 B
#4651 ExecuteNonQuery netcoreapp3.1 1.37μs 0.53ns 1.91ns 0.0104 0 0 768 B
#4651 ExecuteNonQuery net472 1.63μs 0.757ns 2.73ns 0.116 0 0 730 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.2μs 1.56ns 6.04ns 0.0136 0 0 992 B
master CallElasticsearch netcoreapp3.1 1.52μs 0.593ns 2.22ns 0.0137 0 0 992 B
master CallElasticsearch net472 2.39μs 0.988ns 3.83ns 0.159 0.00119 0 1 KB
master CallElasticsearchAsync net6.0 1.35μs 1.07ns 4.16ns 0.0133 0 0 968 B
master CallElasticsearchAsync netcoreapp3.1 1.52μs 0.827ns 3.2ns 0.0139 0 0 1.04 KB
master CallElasticsearchAsync net472 2.48μs 1.21ns 4.68ns 0.167 0.00124 0 1.06 KB
#4651 CallElasticsearch net6.0 1.21μs 0.871ns 3.37ns 0.014 0 0 992 B
#4651 CallElasticsearch netcoreapp3.1 1.49μs 0.333ns 1.25ns 0.0136 0 0 992 B
#4651 CallElasticsearch net472 2.36μs 0.872ns 3.26ns 0.159 0.00119 0 1 KB
#4651 CallElasticsearchAsync net6.0 1.29μs 0.665ns 2.58ns 0.0136 0 0 968 B
#4651 CallElasticsearchAsync netcoreapp3.1 1.51μs 1.87ns 7.26ns 0.0143 0 0 1.04 KB
#4651 CallElasticsearchAsync net472 2.45μs 0.841ns 3.26ns 0.168 0.00121 0 1.06 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.19μs 0.369ns 1.33ns 0.0125 0 0 912 B
master ExecuteAsync netcoreapp3.1 1.48μs 0.633ns 2.45ns 0.012 0 0 912 B
master ExecuteAsync net472 1.66μs 1.02ns 3.96ns 0.138 0.000829 0 875 B
#4651 ExecuteAsync net6.0 1.22μs 0.619ns 2.4ns 0.0128 0 0 912 B
#4651 ExecuteAsync netcoreapp3.1 1.43μs 0.814ns 3.15ns 0.0126 0 0 912 B
#4651 ExecuteAsync net472 1.73μs 0.527ns 2.04ns 0.138 0.000864 0 875 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 3.67μs 2.27ns 8.48ns 0.0273 0 0 1.94 KB
master SendAsync netcoreapp3.1 4.48μs 2.26ns 8.77ns 0.0313 0 0 2.48 KB
master SendAsync net472 7.16μs 2.33ns 9.03ns 0.483 0 0 3.05 KB
#4651 SendAsync net6.0 3.96μs 1.71ns 6.4ns 0.0278 0 0 1.94 KB
#4651 SendAsync netcoreapp3.1 4.49μs 2.72ns 10.2ns 0.0317 0 0 2.48 KB
#4651 SendAsync net472 7.13μs 1.57ns 5.45ns 0.484 0 0 3.05 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.34μs 1.4ns 5.42ns 0.0227 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 1.92μs 0.537ns 1.86ns 0.0215 0 0 1.62 KB
master EnrichedLog net472 2.39μs 0.967ns 3.62ns 0.244 0 0 1.54 KB
#4651 EnrichedLog net6.0 1.27μs 0.588ns 2.2ns 0.0227 0 0 1.62 KB
#4651 EnrichedLog netcoreapp3.1 1.97μs 1.31ns 5.07ns 0.0217 0 0 1.62 KB
#4651 EnrichedLog net472 2.41μs 1.7ns 6.37ns 0.244 0 0 1.54 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 201ns 779ns 0.0566 0 0 4.21 KB
master EnrichedLog netcoreapp3.1 117μs 164ns 613ns 0.0589 0 0 4.21 KB
master EnrichedLog net472 148μs 165ns 641ns 0.668 0.223 0 4.38 KB
#4651 EnrichedLog net6.0 114μs 162ns 628ns 0.0569 0 0 4.21 KB
#4651 EnrichedLog netcoreapp3.1 119μs 293ns 1.14μs 0 0 0 4.21 KB
#4651 EnrichedLog net472 148μs 94ns 364ns 0.663 0.221 0 4.38 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.94μs 1.03ns 3.86ns 0.0305 0 0 2.18 KB
master EnrichedLog netcoreapp3.1 3.84μs 1.84ns 7.14ns 0.029 0 0 2.18 KB
master EnrichedLog net472 4.61μs 1.19ns 4.59ns 0.316 0 0 1.99 KB
#4651 EnrichedLog net6.0 2.79μs 0.585ns 2.19ns 0.0307 0 0 2.18 KB
#4651 EnrichedLog netcoreapp3.1 3.78μs 1.3ns 4.87ns 0.0282 0 0 2.18 KB
#4651 EnrichedLog net472 4.58μs 1.76ns 6.83ns 0.316 0 0 1.99 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.688ns 2.48ns 0.0164 0 0 1.16 KB
master SendReceive netcoreapp3.1 1.64μs 1.04ns 3.9ns 0.0154 0 0 1.16 KB
master SendReceive net472 2.06μs 1.13ns 4.39ns 0.185 0 0 1.16 KB
#4651 SendReceive net6.0 1.37μs 0.624ns 2.34ns 0.0163 0 0 1.16 KB
#4651 SendReceive netcoreapp3.1 1.63μs 1.01ns 3.77ns 0.0155 0 0 1.16 KB
#4651 SendReceive net472 2.01μs 2.14ns 8.28ns 0.185 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.54μs 0.861ns 3.1ns 0.0216 0 0 1.53 KB
master EnrichedLog netcoreapp3.1 3.69μs 1.59ns 6.16ns 0.0202 0 0 1.58 KB
master EnrichedLog net472 3.99μs 0.959ns 3.59ns 0.311 0 0 1.96 KB
#4651 EnrichedLog net6.0 2.56μs 0.919ns 3.56ns 0.0205 0 0 1.53 KB
#4651 EnrichedLog netcoreapp3.1 3.59μs 2.12ns 8.23ns 0.0217 0 0 1.58 KB
#4651 EnrichedLog net472 4.06μs 3.17ns 11.9ns 0.31 0 0 1.96 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4651

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.243 401.00 498.51

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.372ns 1.44ns 0.00755 0 0 536 B
master StartFinishSpan netcoreapp3.1 575ns 0.137ns 0.512ns 0.00709 0 0 536 B
master StartFinishSpan net472 647ns 0.258ns 1ns 0.0854 0 0 538 B
master StartFinishScope net6.0 521ns 0.265ns 0.993ns 0.00917 0 0 656 B
master StartFinishScope netcoreapp3.1 673ns 0.593ns 2.22ns 0.00894 0 0 656 B
master StartFinishScope net472 852ns 0.646ns 2.5ns 0.098 0 0 618 B
#4651 StartFinishSpan net6.0 498ns 0.11ns 0.382ns 0.00751 0 0 536 B
#4651 StartFinishSpan netcoreapp3.1 596ns 2.58ns 9.98ns 0.00722 0 0 536 B
#4651 StartFinishSpan net472 660ns 0.201ns 0.752ns 0.0852 0 0 538 B
#4651 StartFinishScope net6.0 536ns 0.204ns 0.765ns 0.00925 0 0 656 B
#4651 StartFinishScope netcoreapp3.1 719ns 0.476ns 1.84ns 0.00881 0 0 656 B
#4651 StartFinishScope net472 849ns 0.28ns 1.08ns 0.0979 0 0 618 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4651

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.121 794.52 890.64

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 616ns 0.462ns 1.79ns 0.009 0 0 656 B
master RunOnMethodBegin netcoreapp3.1 795ns 0.278ns 1.08ns 0.00913 0 0 656 B
master RunOnMethodBegin net472 919ns 0.506ns 1.96ns 0.0982 0 0 618 B
#4651 RunOnMethodBegin net6.0 563ns 1.52ns 5.88ns 0.00913 0 0 656 B
#4651 RunOnMethodBegin netcoreapp3.1 891ns 0.389ns 1.51ns 0.00887 0 0 656 B
#4651 RunOnMethodBegin net472 991ns 1.26ns 4.87ns 0.0978 0 0 618 B

@andrewlock
Copy link
Member

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!
Loading 
gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4651) (11.557M)   : 0, 11557272
    master (11.411M)   : 0, 11410575
    benchmarks/2.38.0 (11.532M)   : 0, 11531559
    benchmarks/2.9.0 (11.702M)   : 0, 11701871

    section Automatic
    This PR (4651) (8.141M)   : 0, 8140985
    master (8.029M)   : 0, 8029231
    benchmarks/2.38.0 (8.007M)   : 0, 8006818
    benchmarks/2.9.0 (8.520M)   : 0, 8520094

    section Trace stats
    master (8.282M)   : 0, 8281771
    benchmarks/2.38.0 (8.303M)   : 0, 8302876

    section Manual
    This PR (4651) (10.455M)   : 0, 10454833
    master (10.079M)   : 0, 10078776
    benchmarks/2.38.0 (10.141M)   : 0, 10141358

    section Manual + Automatic
    This PR (4651) (7.755M)   : 0, 7755353
    master (7.468M)   : 0, 7468491
    benchmarks/2.38.0 (7.579M)   : 0, 7579310

    section Version Conflict
    master (6.961M)   : 0, 6960831
    benchmarks/2.38.0 (7.066M)   : 0, 7065978
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4651) (9.536M)   : 0, 9535552
    master (9.571M)   : 0, 9571222
    benchmarks/2.38.0 (9.703M)   : 0, 9703171
    benchmarks/2.9.0 (9.518M)   : 0, 9517755

    section Automatic
    This PR (4651) (6.735M)   : 0, 6735067
    master (6.807M)   : 0, 6806672
    benchmarks/2.38.0 (6.646M)   : 0, 6646287

    section Trace stats
    master (6.909M)   : 0, 6908980
    benchmarks/2.38.0 (6.925M)   : 0, 6925272

    section Manual
    This PR (4651) (8.443M)   : 0, 8443030
    master (8.273M)   : 0, 8273041
    benchmarks/2.38.0 (8.478M)   : 0, 8477667

    section Manual + Automatic
    This PR (4651) (6.283M)   : 0, 6282544
    master (6.317M)   : 0, 6317446
    benchmarks/2.38.0 (6.421M)   : 0, 6421392

    section Version Conflict
    master (5.844M)   : 0, 5844362
    benchmarks/2.38.0 (5.868M)   : 0, 5867854
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4651) (10.151M)   : 0, 10150809
    master (10.521M)   : 0, 10520760
    benchmarks/2.38.0 (10.451M)   : 0, 10451481
    benchmarks/2.9.0 (10.049M)   : 0, 10049044

    section Automatic
    This PR (4651) (7.336M)   : 0, 7335735
    master (7.508M)   : 0, 7507847
    benchmarks/2.38.0 (7.619M)   : 0, 7619144
    benchmarks/2.9.0 (7.760M)   : 0, 7759587

    section Trace stats
    master (7.832M)   : 0, 7832385
    benchmarks/2.38.0 (7.836M)   : 0, 7835831

    section Manual
    This PR (4651) (8.992M)   : 0, 8991526
    master (9.406M)   : 0, 9406090
    benchmarks/2.38.0 (9.548M)   : 0, 9548306

    section Manual + Automatic
    This PR (4651) (7.107M)   : 0, 7107009
    master (7.347M)   : 0, 7346786
    benchmarks/2.38.0 (7.321M)   : 0, 7321222

    section Version Conflict
    master (6.660M)   : 0, 6659668
    benchmarks/2.38.0 (6.644M)   : 0, 6643795
Loading 
gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4651) (7.116M)   : 0, 7116154
    master (7.517M)   : 0, 7517420
    benchmarks/2.38.0 (7.569M)   : 0, 7569264
    benchmarks/2.9.0 (7.723M)   : 0, 7723267

    section No attack
    This PR (4651) (2.085M)   : 0, 2084871
    master (2.170M)   : 0, 2169809
    benchmarks/2.38.0 (2.144M)   : 0, 2144152
    benchmarks/2.9.0 (3.201M)   : 0, 3200507

    section Attack
    This PR (4651) (1.658M)   : 0, 1658055
    master (1.745M)   : 0, 1744808
    benchmarks/2.38.0 (1.726M)   : 0, 1726094
    benchmarks/2.9.0 (2.537M)   : 0, 2536997

    section Blocking
    This PR (4651) (3.292M)   : 0, 3292387
    master (3.404M)   : 0, 3403710
    benchmarks/2.38.0 (3.470M)   : 0, 3469785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tonyredondo tonyredondo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tonyredondo @andrewlock