Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debugger Windows integration tests not running #6754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrewlock
Copy link
Member

Summary of changes

Fixes the debugger tests filter so we run Windows Integration tests

Reason for change

The debugger tests were generating an invalid filter, so no tests have been running on Windows.

Implementation details

Fix the check for an empty Filter

Test coverage

This is the test

@andrewlock andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests labels Mar 11, 2025
@andrewlock andrewlock requested a review from a team as a code owner March 11, 2025 10:42
@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (1,004ms)  : 984, 1024
     .   : milestone, 1004,
    master - mean (1,006ms)  : 977, 1034
     .   : milestone, 1006,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (691ms)  : 675, 708
     .   : milestone, 691,
    master - mean (689ms)  : 673, 705
     .   : milestone, 689,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (89ms)  : 88, 91
     .   : milestone, 89,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (643ms)  : 628, 658
     .   : milestone, 643,
    master - mean (648ms)  : 627, 669
     .   : milestone, 648,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (191ms)  : 187, 194
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (1,111ms)  : 1083, 1139
     .   : milestone, 1111,
    master - mean (1,109ms)  : 1089, 1128
     .   : milestone, 1109,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (270ms)  : 266, 273
     .   : milestone, 270,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (878ms)  : 850, 907
     .   : milestone, 878,
    master - mean (878ms)  : 854, 901
     .   : milestone, 878,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6754) - mean (263ms)  : 260, 266
     .   : milestone, 263,
    master - mean (262ms)  : 256, 269
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6754) - mean (855ms)  : 830, 880
     .   : milestone, 855,
    master - mean (857ms)  : 828, 887
     .   : milestone, 857,

@andrewlock andrewlock changed the title Fix Debugger Windows integration tests Fix Debugger Windows integration tests and skip failing Mar 11, 2025
@andrewlock andrewlock changed the title Fix Debugger Windows integration tests and skip failing Fix Debugger Windows integration tests not running Mar 11, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

All test runs ad56738 🔗

2 Total Test Services: 1 Failed, 1 Passed
❄️ 1 with New Flaky

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Total Time Test Service View
dd-trace-dotnet 2120 392 87 267360 4874 65h 52m 7.66s Link
exploration_tests 0 0 0 22085 3 1h 26m 46.5s Link

❌ Failed Tests (2120)

This report shows up to 5 failed tests.

  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - ❄️ Known flaky - Details

    Expand for error
     Expected relevantSpans to contain at least 1 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
    
  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - ❄️ Known flaky - Details

    Expand for error
     Expected relevantSpans to contain at least 1 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
    
  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - ❄️ Known flaky - Details

    Expand for error
     Expected relevantSpans to contain at least 1 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
    
  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - ❄️ Known flaky - Details

    Expand for error
     Expected relevantSpans to contain at least 1 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
    
  • TestExceptionReplay - Datadog.Trace.Debugger.IntegrationTests.ExceptionReplay.AspNetCore5ExceptionReplayEnabledDynamicInstrumentationDisabled - ❄️ Known flaky - Details

    Expand for error
     Expected relevantSpans to contain at least 1 item(s) because we want to ensure that we don't timeout while waiting for spans from the mock tracer agent, but found 0: {empty}.
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages area:tests unit tests, integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant