Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove profiler throughput tests and bump timeouts #6757

Merged

Conversation

andrewlock
Copy link
Member

Summary of changes

Remove the Profiler throughput tests on Windows (like #6752)

Reason for change

These tests fail a lot and we're hoping to migrate away soon anyway. And @gleocadie asked me to remove them 😄

Also saw occasional timeouts in throughput tests, so bump the timeout

Implementation details

Remove the windows job and bump timeouts throughout

Test coverage

This is the test really

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 11, 2025
@andrewlock andrewlock requested a review from a team as a code owner March 11, 2025 15:07
Copy link
Collaborator

@gleocadie gleocadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 11, 2025

Datadog Report

Branch report: andrew/ci/remove-profiler-windowws-throughput-tests
Commit report: cee6c17
Test service: dd-trace-dotnet

✅ 0 Failed, 249509 Passed, 2393 Skipped, 19h 36m 34.45s Total Time

@andrewlock
Copy link
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (69ms)  : 67, 72
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (1,010ms)  : 990, 1029
     .   : milestone, 1010,
    master - mean (1,006ms)  : 977, 1034
     .   : milestone, 1006,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (102ms)  : 100, 105
     .   : milestone, 102,
    master - mean (102ms)  : 100, 105
     .   : milestone, 102,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (691ms)  : 674, 708
     .   : milestone, 691,
    master - mean (689ms)  : 673, 705
     .   : milestone, 689,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (90ms)  : 87, 92
     .   : milestone, 90,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (644ms)  : 622, 665
     .   : milestone, 644,
    master - mean (648ms)  : 627, 669
     .   : milestone, 648,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (191ms)  : 186, 196
     .   : milestone, 191,
    master - mean (191ms)  : 187, 194
     .   : milestone, 191,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (1,114ms)  : 1087, 1140
     .   : milestone, 1114,
    master - mean (1,109ms)  : 1089, 1128
     .   : milestone, 1109,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (271ms)  : 268, 274
     .   : milestone, 271,
    master - mean (271ms)  : 267, 275
     .   : milestone, 271,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (881ms)  : 853, 910
     .   : milestone, 881,
    master - mean (878ms)  : 854, 901
     .   : milestone, 878,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6757) - mean (264ms)  : 260, 267
     .   : milestone, 264,
    master - mean (262ms)  : 256, 269
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6757) - mean (857ms)  : 829, 886
     .   : milestone, 857,
    master - mean (857ms)  : 828, 887
     .   : milestone, 857,

@andrewlock andrewlock merged commit 4d13fff into master Mar 11, 2025
142 of 146 checks passed
@andrewlock andrewlock deleted the andrew/ci/remove-profiler-windowws-throughput-tests branch March 11, 2025 17:12
@github-actions github-actions bot added this to the vNext-v3 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants