Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decommission old throughput tests #6786

Closed
wants to merge 1 commit into from
Closed

Decommission old throughput tests #6786

wants to merge 1 commit into from
+0 −230

Conversation

faydef
Copy link
Contributor

@faydef faydef commented Mar 20, 2025

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

@github-actions github-actions bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Mar 20, 2025
@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 20, 2025 •
edited
Loading

Datadog Report

Branch report: fayssal/decommission-azure-throughput-tests
Commit report: 71fb44e
Test service: dd-trace-dotnet

✅ 0 Failed, 200346 Passed, 1415 Skipped, 12h 58m 55.35s Total Time

@andrewlock
Copy link
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

 
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (69ms)  : 66, 73
     .   : milestone, 69,
    master - mean (69ms)  : 66, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (1,005ms)  : 981, 1029
     .   : milestone, 1005,
    master - mean (1,009ms)  : 987, 1031
     .   : milestone, 1009,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (102ms)  : 101, 104
     .   : milestone, 102,
    master - mean (103ms)  : 101, 104
     .   : milestone, 103,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (686ms)  : 665, 708
     .   : milestone, 686,
    master - mean (690ms)  : 673, 707
     .   : milestone, 690,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (89ms)  : 87, 91
     .   : milestone, 89,
    master - mean (89ms)  : 88, 91
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (645ms)  : 624, 665
     .   : milestone, 645,
    master - mean (645ms)  : 631, 659
     .   : milestone, 645,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (190ms)  : 186, 194
     .   : milestone, 190,
    master - mean (190ms)  : 185, 194
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (1,106ms)  : 1078, 1134
     .   : milestone, 1106,
    master - mean (1,107ms)  : 1075, 1138
     .   : milestone, 1107,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (268ms)  : 263, 274
     .   : milestone, 268,
    master - mean (269ms)  : 265, 273
     .   : milestone, 269,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (878ms)  : 845, 911
     .   : milestone, 878,
    master - mean (878ms)  : 849, 906
     .   : milestone, 878,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6786) - mean (263ms)  : 259, 267
     .   : milestone, 263,
    master - mean (262ms)  : 257, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (6786) - mean (863ms)  : 826, 900
     .   : milestone, 863,
    master - mean (858ms)  : 824, 891
     .   : milestone, 858,

@andrewlock
Copy link
Member

Benchmarks Report for tracer 🐌

Benchmarks for #6786 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.145
  • 1 benchmarks are slower, with geometric mean 1.158
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 8.2μs 43.3ns 225ns 0.0159 0.00797 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.4μs 57.2ns 319ns 0.00997 0 0 5.81 KB
master StartStopWithChild net472 16.1μs 57.3ns 222ns 1.03 0.299 0.097 6.22 KB
#6786 StartStopWithChild net6.0 7.81μs 44.7ns 326ns 0.0153 0.00764 0 5.61 KB
#6786 StartStopWithChild netcoreapp3.1 10.4μs 59.3ns 411ns 0.0258 0.0103 0 5.8 KB
#6786 StartStopWithChild net472 16μs 51.8ns 201ns 1.03 0.292 0.0975 6.2 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 500μs 714ns 2.77μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 640μs 669ns 2.5μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 853μs 1.03μs 4μs 0.425 0 0 3.3 KB
#6786 WriteAndFlushEnrichedTraces net6.0 498μs 359ns 1.39μs 0 0 0 2.7 KB
#6786 WriteAndFlushEnrichedTraces netcoreapp3.1 660μs 771ns 2.98μs 0 0 0 2.7 KB
#6786 WriteAndFlushEnrichedTraces net472 865μs 673ns 2.52μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 449ns 1.74μs 0.189 0 0 14.47 KB
master SendRequest netcoreapp3.1 144μs 243ns 942ns 0.217 0 0 17.27 KB
master SendRequest net472 0.000649ns 0.000312ns 0.00121ns 0 0 0 0 b
#6786 SendRequest net6.0 134μs 417ns 1.56μs 0.197 0 0 14.47 KB
#6786 SendRequest netcoreapp3.1 142μs 569ns 2.2μs 0.211 0 0 17.27 KB
#6786 SendRequest net472 0.00109ns 0.00047ns 0.00176ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 575μs 3.04μs 16.3μs 0.563 0 0 41.55 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 695μs 3.98μs 32.8μs 0.319 0 0 41.88 KB
master WriteAndFlushEnrichedTraces net472 849μs 3.93μs 15.7μs 8.69 2.48 0.414 53.29 KB
#6786 WriteAndFlushEnrichedTraces net6.0 577μs 3.28μs 23.9μs 0.539 0 0 41.64 KB
#6786 WriteAndFlushEnrichedTraces netcoreapp3.1 678μs 3.58μs 17.5μs 0.359 0 0 41.81 KB
#6786 WriteAndFlushEnrichedTraces net472 863μs 3.99μs 16μs 8.19 2.59 0.431 53.32 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.33μs 1.53ns 5.74ns 0.0146 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.76μs 1.21ns 4.54ns 0.0131 0 0 1.02 KB
master ExecuteNonQuery net472 2μs 3.77ns 14.6ns 0.157 0.000998 0 987 B
#6786 ExecuteNonQuery net6.0 1.27μs 0.822ns 3.18ns 0.014 0 0 1.02 KB
#6786 ExecuteNonQuery netcoreapp3.1 1.72μs 1.72ns 6.65ns 0.0137 0 0 1.02 KB
#6786 ExecuteNonQuery net472 2.07μs 2.37ns 8.88ns 0.156 0.00103 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 0.825ns 3.19ns 0.0133 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.55μs 0.772ns 2.89ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.56μs 1.4ns 5.42ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.36μs 0.503ns 1.74ns 0.0128 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.64μs 2.5ns 9.7ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.76μs 1.28ns 4.95ns 0.166 0 0 1.05 KB
#6786 CallElasticsearch net6.0 1.27μs 0.861ns 3.33ns 0.0133 0 0 976 B
#6786 CallElasticsearch netcoreapp3.1 1.64μs 1.2ns 4.48ns 0.013 0 0 976 B
#6786 CallElasticsearch net472 2.62μs 1.81ns 7.01ns 0.158 0 0 995 B
#6786 CallElasticsearchAsync net6.0 1.26μs 0.992ns 3.71ns 0.0132 0 0 952 B
#6786 CallElasticsearchAsync netcoreapp3.1 1.72μs 0.64ns 2.22ns 0.0139 0 0 1.02 KB
#6786 CallElasticsearchAsync net472 2.67μs 1.61ns 6.23ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.398ns 1.43ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.72μs 0.545ns 2.04ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.76μs 0.474ns 1.77ns 0.145 0 0 915 B
#6786 ExecuteAsync net6.0 1.31μs 0.779ns 2.91ns 0.0131 0 0 952 B
#6786 ExecuteAsync netcoreapp3.1 1.68μs 1.02ns 3.82ns 0.0126 0 0 952 B
#6786 ExecuteAsync net472 1.77μs 0.369ns 1.33ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.33μs 2.46ns 9.19ns 0.0326 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.53μs 2.97ns 11.5ns 0.0386 0 0 2.85 KB
master SendAsync net472 7.53μs 2.65ns 10.2ns 0.493 0 0 3.12 KB
#6786 SendAsync net6.0 4.31μs 5.37ns 20.8ns 0.0321 0 0 2.31 KB
#6786 SendAsync netcoreapp3.1 5.27μs 3.04ns 11.8ns 0.037 0 0 2.85 KB
#6786 SendAsync net472 7.44μs 1.44ns 5.38ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.54μs 1.34ns 5.03ns 0.024 0 0 1.69 KB
master EnrichedLog netcoreapp3.1 2.16μs 1.12ns 4.19ns 0.0221 0 0 1.69 KB
master EnrichedLog net472 2.6μs 1.48ns 5.75ns 0.258 0 0 1.62 KB
#6786 EnrichedLog net6.0 1.53μs 0.815ns 3.05ns 0.0242 0 0 1.69 KB
#6786 EnrichedLog netcoreapp3.1 2.32μs 1.08ns 4.05ns 0.0234 0 0 1.69 KB
#6786 EnrichedLog net472 2.48μs 1.19ns 4.62ns 0.257 0 0 1.62 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 211ns 816ns 0.0558 0 0 4.3 KB
master EnrichedLog netcoreapp3.1 116μs 134ns 501ns 0 0 0 4.3 KB
master EnrichedLog net472 148μs 165ns 640ns 0.669 0.223 0 4.49 KB
#6786 EnrichedLog net6.0 111μs 135ns 523ns 0.0554 0 0 4.3 KB
#6786 EnrichedLog netcoreapp3.1 118μs 328ns 1.27μs 0.0593 0 0 4.3 KB
#6786 EnrichedLog net472 149μs 218ns 844ns 0.67 0.223 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.16μs 1.7ns 6.13ns 0.0316 0 0 2.25 KB
master EnrichedLog netcoreapp3.1 4.09μs 0.812ns 2.81ns 0.0308 0 0 2.25 KB
master EnrichedLog net472 4.87μs 2.45ns 9.15ns 0.328 0 0 2.07 KB
#6786 EnrichedLog net6.0 3.21μs 0.901ns 3.49ns 0.032 0 0 2.25 KB
#6786 EnrichedLog netcoreapp3.1 4.29μs 2.57ns 9.96ns 0.0301 0 0 2.25 KB
#6786 EnrichedLog net472 4.97μs 4.41ns 17.1ns 0.328 0 0 2.07 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.31μs 0.571ns 2.14ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 1.27ns 4.92ns 0.0153 0 0 1.14 KB
master SendReceive net472 2.09μs 0.933ns 3.61ns 0.183 0 0 1.16 KB
#6786 SendReceive net6.0 1.31μs 0.875ns 3.39ns 0.0157 0 0 1.14 KB
#6786 SendReceive netcoreapp3.1 1.81μs 0.717ns 2.78ns 0.0152 0 0 1.14 KB
#6786 SendReceive net472 2.01μs 0.878ns 3.4ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.86μs 0.947ns 3.67ns 0.0228 0 0 1.62 KB
master EnrichedLog netcoreapp3.1 4.07μs 1.32ns 4.95ns 0.0223 0 0 1.67 KB
master EnrichedLog net472 4.34μs 2.43ns 9.4ns 0.328 0 0 2.07 KB
#6786 EnrichedLog net6.0 2.83μs 0.458ns 1.65ns 0.0227 0 0 1.62 KB
#6786 EnrichedLog netcoreapp3.1 4.1μs 1.33ns 5.14ns 0.0225 0 0 1.67 KB
#6786 EnrichedLog net472 4.57μs 1.84ns 7.11ns 0.326 0 0 2.07 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6786

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.158 473.12 547.80

Faster 🎉 in #6786

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1 1.145 760.19 664.13

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 420ns 0.129ns 0.481ns 0.00798 0 0 576 B
master StartFinishSpan netcoreapp3.1 589ns 0.345ns 1.29ns 0.00748 0 0 576 B
master StartFinishSpan net472 674ns 0.719ns 2.79ns 0.0918 0 0 578 B
master StartFinishScope net6.0 473ns 0.0729ns 0.273ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 760ns 0.543ns 2.1ns 0.00933 0 0 696 B
master StartFinishScope net472 855ns 0.228ns 0.883ns 0.104 0 0 658 B
#6786 StartFinishSpan net6.0 412ns 0.112ns 0.434ns 0.00804 0 0 576 B
#6786 StartFinishSpan netcoreapp3.1 632ns 1.44ns 5.58ns 0.00762 0 0 576 B
#6786 StartFinishSpan net472 745ns 0.409ns 1.47ns 0.0917 0 0 578 B
#6786 StartFinishScope net6.0 548ns 0.178ns 0.691ns 0.00966 0 0 696 B
#6786 StartFinishScope netcoreapp3.1 664ns 0.316ns 1.18ns 0.00931 0 0 696 B
#6786 StartFinishScope net472 788ns 0.236ns 0.883ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 670ns 0.208ns 0.804ns 0.00975 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 958ns 0.361ns 1.35ns 0.00909 0 0 696 B
master RunOnMethodBegin net472 1.05μs 0.445ns 1.67ns 0.104 0 0 658 B
#6786 RunOnMethodBegin net6.0 618ns 0.17ns 0.634ns 0.00974 0 0 696 B
#6786 RunOnMethodBegin netcoreapp3.1 960ns 1.1ns 4.27ns 0.00909 0 0 696 B
#6786 RunOnMethodBegin net472 1.08μs 0.324ns 1.25ns 0.104 0 0 658 B

@faydef faydef closed this Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area:builds project files, build scripts, pipelines, versioning, releases, packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@faydef @andrewlock