Integrate Weavevm Bundler #12158
Draft
Integrate Weavevm Bundler #12158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @codingknite, thanks for your pull request to add the awesome WeaveVM to the FileService plugin. It looks like the CI tasks failed because they were unable to fetch code from your repository. Just leave them as they are—the only necessary task is the build task. We will need it to check the storage function manually. |
|
Hey @guanbinrui thanks, let me fix the build |
|
Hey @guanbinrui pushed some changes, the build should now be fixed. Please let me know in case of anything |
Jack-Works
reviewed
Mar 14, 2025
package.json
Outdated
| @@ -51,11 +51,13 @@ | |||
| "@types/react-dom": "npm:types-react-dom@beta", | |||
| "@typescript/lib-dom": "npm:@types/web@^0.0.183", | |||
| "buffer": "^6.0.3", | |||
| "bundler-upload-sdk": "^2.1.1", | |||
There was a problem hiding this comment.
please do not install those dependencies at the root project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MF-0000