Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom fonts #2981

Merged
merged 1 commit into from
Mar 24, 2025
Merged

Add support for custom fonts #2981

merged 1 commit into from
Mar 24, 2025

Conversation

valentin0h
Copy link
Contributor

@valentin0h valentin0h commented Mar 14, 2025

Adds support for custom fonts in GitBook by dynamically generating @font-face rules from user-defined font configurations and preloading the key font sources. It integrates these custom fonts into the layout and OG image generation

Copy link

changeset-bot bot commented Mar 14, 2025

🦋 Changeset detected

Latest commit: dedc654

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
gitbook-v2 Patch
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

argos-ci bot commented Mar 14, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) ✅ No changes detected - Mar 24, 2025, 7:08 AM
customers-v2 (Inspect) ✅ No changes detected - Mar 24, 2025, 7:10 AM
default (Inspect) 👍 Changes approved 2 changed Mar 24, 2025, 7:11 AM
v2-vercel (Inspect) ✅ No changes detected - Mar 24, 2025, 7:12 AM

@valentin0h valentin0h force-pushed the custom-fonts branch 3 times, most recently from 736c95e to ea6f29d Compare March 17, 2025 09:37
Copy link
Contributor

@emmerich emmerich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, I'm not sure about the use of ReactDOM.preload in SSR though

Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants