Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to the first ID as being active in scroll detection #3036

Conversation

SamyPesse
Copy link
Member

This PR fixes https://linear.app/gitbook-x/issue/RND-6694/pill-highlighting-missing-on-page-outline-navigation

The previous logic defaulted to null and kept the value as null if no heading was in the viewport, but it was inconsistent with how the pill was displayed when scrolling: scrolling back to the top of the page still showed the first item as active.

Copy link

linear bot commented Mar 25, 2025

Copy link

changeset-bot bot commented Mar 25, 2025

⚠️ No Changeset found

Latest commit: 084b89f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

argos-ci bot commented Mar 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
customers-v1 (Inspect) 👍 Changes approved 24 changed Mar 25, 2025, 2:14 PM
customers-v2 (Inspect) 👍 Changes approved 24 changed Mar 25, 2025, 2:17 PM
default (Inspect) 👍 Changes approved 2 changed Mar 25, 2025, 2:17 PM
v2-vercel (Inspect) ✅ No changes detected - Mar 25, 2025, 2:19 PM

@SamyPesse SamyPesse merged commit 27de1cd into main Mar 25, 2025
18 checks passed
@SamyPesse SamyPesse deleted the samy/rnd-6694-pill-highlighting-missing-on-page-outline-navigation branch March 25, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants