Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convex Hull node #1673

Open
Kakapio opened this issue Mar 11, 2024 · 6 comments · May be fixed by #2436
Open

Convex Hull node #1673

Kakapio opened this issue Mar 11, 2024 · 6 comments · May be fixed by #2436
Labels
Good First Issue Good for newcomers

Comments

@Kakapio
Copy link
Contributor

Kakapio commented Mar 11, 2024

This node should convert vector shapes into convex hulls of their shapes, preserving their convex curves and bridging their concave parts with straight lines.

@Keavon Just wanted a run-down of how you want this to work. I'll be implementing a standard algorithm but wanted to ask if you had any specific functionality in mind.

Edit:
Information for whoever wants to tackle this task:

While there is plenty of literature about building the convex hull from polygons (polylines), there is much less on the internet about algorithms for doing that from bezier curves. You'll have to do some additional research to solve this, either through Googling for online resources or reading academic papers or thinking through a solution to the problem yourself as an extension of one of the polyline algorithms. The same algorithm needs to work for both shapes such as a hexagon and a circle.

@0HyperCube
Copy link
Member

@Kakapio creating a convex hull from points is reasonably well explored e.g. gift wrap algorithm.

@Kakapio
Copy link
Contributor Author

Kakapio commented Mar 11, 2024

@Kakapio creating a convex hull from points is reasonably well explored e.g. gift wrap algorithm.

Sorry, I think my initial post was a little unclear. I was more asking if there was any specific functionality the team wanted? If not, I'll just go ahead and implement it.

@0HyperCube
Copy link
Member

I would expect there to be a node with some vector data to be passed in containing some points and some vector data containing a region that is the convex hull to be output.

@Keavon Keavon changed the title Convex Hull Node Convex Hull node Mar 12, 2024
@Keavon
Copy link
Member

Keavon commented Mar 12, 2024

This task is free.

@Keavon Keavon added Feature Good First Issue Good for newcomers labels Jun 9, 2024
@g-vitrac
Copy link

g-vitrac commented Dec 19, 2024

Hey @Keavon if this task is still free i'd like to try working on it !

@Keavon
Copy link
Member

Keavon commented Dec 19, 2024

@g-vitrac go for it!

@Keavon Keavon removed the Rust label Dec 30, 2024
@Keavon Keavon removed the Feature label Jan 19, 2025
@MixedMatched MixedMatched linked a pull request Mar 14, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for newcomers
Projects
Status: Short-Term
Development

Successfully merging a pull request may close this issue.

4 participants