Remove subtyping for () from node graph type system #2418
+9
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrueDoctor
approved these changes
Mar 10, 2025
TrueDoctor
approved these changes
Mar 11, 2025
|
@bradrn can you remove the unnecessary import? (basically run cargo check) |
|
Other than that everything seems to be fine |
TrueDoctor
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current type system for the node graph has a special case where all types are considered subtypes of the unit type
(). However, it seems that this case never occurs in practice — I can’t find anything which breaks when this case is removed. Furthermore, it makes the type system (which is already somewhat confusing) even more difficult to reason about.