Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chapter 12] Traverse is taken out of the blue #481

Open
felipegmarques opened this issue Oct 9, 2018 · 4 comments
Open

[Chapter 12] Traverse is taken out of the blue #481

felipegmarques opened this issue Oct 9, 2018 · 4 comments
Labels

Comments

@felipegmarques
Copy link

In Chapter 12, traverse is presented out of the blue.
sequence is explained, but in the section Type Feng Shui, traverse is not explained.

@KtorZ
Copy link
Member

KtorZ commented Oct 10, 2018

You mean, not explained like in "There's a full section about it also giving implementation details" 😄 ?

I believe it's fine on this one 👍 . Maybe it could deserve a small note in brackets like

traverse (detailed in the next section)

Or something like this. Happy to take PRs 😃

@KtorZ KtorZ closed this as completed Oct 10, 2018
@felipegmarques
Copy link
Author

Sorry for the poor explained issue. 😞
I end up writing it on a hurry.

In section Type Feng Shui, it starts saying: The Traversable interface consists of two glorious functions: sequence and traverse., which creates an expectation that traverse would be explained.

Then in section Effect Assortment, there is an example, a little bit more high-level than the ones presented for sequence in the begin of Type Feng Shui.

When I arrived at this part I did not understand what traverse behaviour was and its motivation.
I end up looking for other articles explaining it, specifically this one.

Finally, I understand this issue is a result of my experience reading the book and maybe it was not an issue for other people. In general, the experience reading this book has being very satisfatory and I really appreciate what you guys have done! 😄

@KtorZ
Copy link
Member

KtorZ commented Oct 10, 2018

Going again through reading, it could deserve a small line of introduction indeed. Even before diving into what sequences is.

@KtorZ KtorZ reopened this Oct 10, 2018
@KtorZ KtorZ added the TODO label Oct 10, 2018
@sevillaarvin
Copy link

I'm having a really hard time understanding traverse. I understand the type signature in that it's like map but it will wrap the values inside the functor instead of wrapping the functor itself, but I still don't understand it well enough to come up with a valid implementation and examples.

Unfortunately the link provided is dead, I will link a webarchive link below for reference:

https://web.archive.org/web/20201023080122/https://sidburn.github.io/blog/2016/04/14/sequence-and-traverse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants