CMake: Pass OpenMP compiler and linker flags through CMake targets
#5180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywwry66
force-pushed
the
openmp_use_cmake
branch
2 times, most recently
from
a6e2183 to
b0746c7
Compare
ywwry66
force-pushed
the
openmp_use_cmake
branch
2 times, most recently
from
bf2f49f to
18ccac9
Compare
|
Ok, this is ready. If appropriate, I can also remove all OpenMP related code in |
|
see #5169 for the needed setup |
|
A successful test on Linux x86_64, where libomp is installed system-wide in /usr/. I ran the following: and the linkage is correct: |
dimpase
approved these changes
Mar 18, 2025
4 tasks
|
Also works on M1 up to date system, with openblas.pc looks correct too. |
Using `OpenMP::OpenMP_LANG` targets for CMake is less error-prone than passing the compiler and linker flags manually. Furthermore, it allows the user to customize those flags by setting `OpenMP_LANG_FLAGS`, `OpenMP_LANG_LIB_NAMES`, and `OpenMP_omp_LIBRARY`.
ywwry66
force-pushed
the
openmp_use_cmake
branch
from
18ccac9 to
251c3f8
Compare
ywwry66
commented
Mar 27, 2025
| get_target_property(OMP_C_LIB OpenMP::OpenMP_C INTERFACE_LINK_LIBRARIES) | ||
| get_target_property(OMP_Fortran_LIB OpenMP::OpenMP_Fortran INTERFACE_LINK_LIBRARIES) | ||
| if (NOT OMP_C_LIB STREQUAL OMP_Fortran_LIB) | ||
| message(FATAL_ERROR "Multiple OpenMP runtime libraries detected. Mixed OpenMP runtime linkage is dangerous. You may pass -DOpenMP_LANG_LIB_NAMES and -DOpenMP_omp_LIBRARY to manually choose the OpenMP library.") |
There was a problem hiding this comment.
The previous failure in the GitHub workflow was caused by this check due to mixed linkage to both libomp and libgomp. I have updated the workflow in the latest commit and it should pass the check now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
OpenMP::OpenMP_LANGtargets for CMake is less error-prone than passing the compiler and linker flags manually. Furthermore, it allows the user to customize those flags by settingOpenMP_LANG_FLAGS,OpenMP_LANG_LIB_NAMES, andOpenMP_omp_LIBRARY.