This repository was archived by the owner on Jan 2, 2019. It is now read-only.
Removed an error for zoom scale in favor of a default value. #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or prevents files from going through when in reality it might better to simply default the value on something like zoom scale. The end users of software made using PHPExcel will not know how to handle an error like this.
Preparing for Packagist
|
Thank you for your contribution, however PHPExcel development for next version has moved under its new name PhpSpreadsheet. So please consider heading over to PhpSpreadsheet to contribute patches and features. Pull Requests will no longer be accepted for PHPExcel. If you decide to submit a PR to PhpSpreadsheet, we should adopt a similar strategy than in PHPOffice/PhpSpreadsheet#186, that is keep the validation for normal usage, but allow a non-validated value only when reading files. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error prevents files from going through when in reality it might better to simply default the value on something like zoom scale. The end users of software made using PHPExcel will not know how to handle an error like this.