Add tracking changes for Heading or Title in case of docx reader #1376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 22, 2018 16:09
|
nice @moromete, you know you can run the test/checks locally by running Could you please check the code coverage report? There are some new lines not covered. |
troosan
reviewed
Dec 26, 2018
| * | ||
| * @return string the HTML, an empty string if no track change information | ||
| */ | ||
| private function writeTrackChangeOpening() |
There was a problem hiding this comment.
should avoid code duplication and move those 2 methods to the parent AbstractElement
troosan
added
the
Status: Waiting for feedback
Progi1984
force-pushed
the
master
branch
3 times, most recently
from
2d9f999 to
e458249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tracking changes for Heading or Title for docx reader
Also added tracking changes in case of Title for HTML writer