Contiguous checking #105

kngwyu · 2019-07-03T11:31:06Z

Resolves #101.
Add methods to check the array is contiguous or not and use these methods in as_slice and as_slice_mut.

- To resolve PyO3#101, we check if the array is contiguous when getting a slice

rth · 2019-07-03T11:35:06Z

src/array.rs

+            | self.check_flag(npyffi::NPY_ARRAY_F_CONTIGUOUS)
+    }
+
+    pub fn is_forran_contiguous(&self) -> bool {


typo: fortran

Oops, thank you for pointing out.

rth · 2019-07-03T11:37:24Z

src/array.rs

+        unsafe { (*self.as_array_ptr()).flags & flag == flag }
+    }
+
+    pub fn is_contiguous(&self) -> bool {


Maybe worth adding a docstring indicating that this returns true if the array is either C or Fortran contiguous

kngwyu · 2019-07-04T03:40:22Z

I'm going to add a method to get a contiguous array in the next PR.

Add is_*contiguous methods + Modify as_slice* returns Result

2b411d2

- To resolve PyO3#101, we check if the array is contiguous when getting a slice

rth reviewed Jul 3, 2019

View reviewed changes

kngwyu added 3 commits July 4, 2019 01:52

Fix doc examples where we use array.as_slice

3ad4272

Add an example of PyArray::is_contiguous

a3ba23b

Fix README example

123fbb5

kngwyu merged commit 83761e6 into PyO3:master Jul 4, 2019

kngwyu deleted the contiguous branch July 4, 2019 03:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Contiguous checking #105

Contiguous checking #105

kngwyu commented Jul 3, 2019

rth Jul 3, 2019

kngwyu Jul 3, 2019

rth Jul 3, 2019 •

edited

Loading

kngwyu commented Jul 4, 2019

Contiguous checking #105

Contiguous checking #105

Conversation

kngwyu commented Jul 3, 2019

rth Jul 3, 2019

Choose a reason for hiding this comment

kngwyu Jul 3, 2019

Choose a reason for hiding this comment

rth Jul 3, 2019 • edited Loading

Choose a reason for hiding this comment

kngwyu commented Jul 4, 2019

rth Jul 3, 2019 •

edited

Loading