Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid import numpy::* in examples #53

Closed
droundy opened this issue Aug 23, 2018 · 1 comment
Closed

avoid import numpy::* in examples #53

droundy opened this issue Aug 23, 2018 · 1 comment

Comments

@droundy
Copy link

droundy commented Aug 23, 2018

This makes it very hard to read and understand the code. I can understand (but don't like) the use pyo3::prelude::*;, but having two wildcard imports makes it impossible to guess what any given symbol might mean.

@kngwyu
Copy link
Member

kngwyu commented Aug 24, 2018

Thanks for reporting!

having two wildcard imports makes it impossible to guess what any given symbol might mean

This sounds reasonable. I'm going to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants