Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi mini-improvements #1

Closed
wants to merge 1 commit into from
Closed

Multi mini-improvements #1

wants to merge 1 commit into from

Conversation

Hugome
Copy link

@Hugome Hugome commented May 15, 2017

  • Option for simple mode
  • Option for the main icon
    README and demo update
    Added Yarn lockfile

 - Option for simple mode
 - Option for  the main icon
README and demo update
Added Yarn lockfile
@hazzo
Copy link
Contributor

hazzo commented May 15, 2017

Hi mate,
thanks for taking your time on doing a PR.
Some ideas are good but not implementable in that way.

Is it necessary to make the action button "simple" ? An html element with styles would cover that necessity. I don't think someone it's going to download the component for using it just as a simple button.

And in the other hand modifying the main icon it's a great idea but the animation has to be taken into consideration. If you change the icon now and then click the button you will get a rotated element that does not cope with the material design rules.

Please if you want to make another PR, one for each individual feature.

Thanks again!

PD: Take note that the contributors section in the package.json should not be modified. If your PR is accepted you will appear in github as one.

@hazzo hazzo closed this May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants