-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Buildsystem: Makefile of Common Board Directories never called without adding DIRS
#21298
Comments
Another way to check is the Unchanged master:
With `DIRS` commented out:
One thing that is interesting though is that in both cases, the (One additional thing to note is that the module used by the But even if the name of the module reflects the name of the folder, the Log of `info-build`
Searching with grep for samdx1-arduino-bootloader:
|
Thanks for opening the issue! I've also just now experienced this behavior while working on #21242. Would probably need some more digging into the build system to be fixed. |
I went through the debug log ( Lines 30 to 31 in f4d74ff
Looking at the other targets that start with Lines 4 to 5 in f4d74ff
RIOT/boards/hip-badge/Makefile Line 3 in f4d74ff
RIOT/cpu/arm7tdmi_gba/Makefile Line 5 in f4d74ff
and various others. Considering this is a giant can of worms again, I would like to postpone this and not make it a requirement for #21281. |
Sure, fine with me. At least we now have a tracking issue :) |
Apparently using the There never was a provision to fetch the |
Description
During the development of #21281 I noticed that the common board directories that have .c files, explicitly require that the common directory is added to the
DIRS
variable in the board'sMakefile
.This is for example the case for the
particle-*
boards, that include theboards/common/particle-mesh
folder:RIOT/boards/particle-xenon/Makefile
Lines 1 to 5 in 685acb9
Even though the
boards_common_particle_mesh
module defined by theparticle-mesh
common board is added in theMakefile.dep
, theboards/common/particle-mesh/Makefile
will never be called without theDIRS +=
definition.RIOT/boards/particle-xenon/Makefile.dep
Lines 1 to 3 in 685acb9
Steps to reproduce the issue
Compile an application of your choice (for example
tests/sys/shell
) for theparticle-xenon
and observe the compile output. It should includeboards/common/particle-mesh
:Comment out line 3 of the
boards/particle-xenon/Makefile
(theDIRS
line) and observe the output again:The
boards/common/particle-mesh
folder is not included anymore and no error is generated.Expected results
The build system should include the
boards/common/particle-mesh
directory if theboards_common_particle-mesh
module is used.The
particle-*
boards are just an example here, the same is true for boards that use thesamdx1-arduino-bootloader
: https://github.com/search?q=repo%3ARIOT-OS%2FRIOT+boards_common_samdx1-arduino-bootloader&type=codeI'm not sure where to look and what to possibly change in the build system, so hints would be very welcome.
Actual results
See above.
Versions
This happens with the latest RIOT master.
The text was updated successfully, but these errors were encountered: