Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Link assertion example in using_selenium.en.md #2161

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

automatealchemist
Copy link
Contributor

@automatealchemist automatealchemist commented Feb 8, 2025

User description

Added a reference to the existing assertion code (assertEquals("Web form", title)) in usingselenium.en.md to improve documentation clarity.

Description

  • Linked the assertion line in the Kotlin example section.
  • Ensured consistency in the documentation.

Motivation and Context

  • Improves visibility of assertion usage in Selenium’s Kotlin examples.
  • Enhances documentation clarity and consistency.

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally, and I am sure it works.

Copy link

netlify bot commented Feb 8, 2025

👷 Deploy request for selenium-dev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 32df7af

@CLAassistant
Copy link

CLAassistant commented Feb 8, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor Author

@automatealchemist automatealchemist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request adds a link assertion example to the Selenium documentation. I have updated the code block reference in the Kotlin section. Please review and let me know if any changes are needed. Looking forward to your feedback. Thank you!

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @automatealchemist ,

Thank you for the PR. Could you please do the similar changes in other translated pages too which are other than in english!

@automatealchemist
Copy link
Contributor Author

Could you please do the similar changes in other translated pages too which are other than in english!

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants