Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute: Added algorithm and tests for Unique Paths DP problem #1118

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Jaiharishan
Copy link

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not edit the package-lock.json

@Jaiharishan
Copy link
Author

Do not edit the package-lock.json

Will revert back to the previous one. Is it fine?

@Jaiharishan
Copy link
Author

@raklaptudirm I have made the changes you told. Check if its fine now.

@Jaiharishan
Copy link
Author

Jaiharishan commented Oct 3, 2022

I have made all cases to some under single test block as you said.

@Jaiharishan
Copy link
Author

Is this fine now?

appgurueu
appgurueu previously approved these changes Oct 3, 2022
@appgurueu appgurueu added the algorithm Adds or improves an algorithm label Oct 3, 2022
Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some more comments in your code, it can be hard to understand for someone trying to learn.

@Jaiharishan
Copy link
Author

Jaiharishan commented Oct 3, 2022 via email

@Jaiharishan
Copy link
Author

I have added comments, is it ok now?

@Jaiharishan
Copy link
Author

Do I need to change anything sir?

Copy link
Member

@raklaptudirm raklaptudirm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a short explanation of how the algorithm works.

@Jaiharishan
Copy link
Author

Jaiharishan commented Oct 5, 2022 via email

@stale
Copy link

stale bot commented Nov 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
algorithm Adds or improves an algorithm stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants