algorithm: quadratic formula #1151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Oct 9, 2022
Maths/test/QuadraticFormula.test.js
Outdated
| @@ -0,0 +1,21 @@ | |||
| import { quadraticFormula } from '../QuadraticFormula' | |||
|
|
|||
| test('Testing on quadraticFormula', () => { | |||
There was a problem hiding this comment.
appgurueu
reviewed
Oct 9, 2022
Maths/QuadraticFormula.js
Outdated
| * @example quadraticFormula(1, -3, 8) = 'the roots do not exist or the roots are imaginary' | ||
| */ | ||
|
|
||
| const quadraticFormula = (a, b, c) => { |
There was a problem hiding this comment.
Please rename to solveQuadraticEquation
appgurueu
reviewed
Oct 9, 2022
Maths/QuadraticFormula.js
Outdated
| } | ||
| const discriminant = (b ** 2) - (4 * a * c) | ||
| const denominator = 2 * a | ||
| let answer = '' |
There was a problem hiding this comment.
Don't use strings; instead, return an array of solutions (empty array for no solutions, array with single item for one solution, two items for two solutions).
appgurueu
reviewed
Oct 9, 2022
Maths/QuadraticFormula.js
Outdated
| if (typeof a !== 'number' || typeof b !== 'number' || typeof c !== 'number') { | ||
| return new TypeError('Some argument is not a number.') | ||
| } | ||
| const discriminant = (b ** 2) - (4 * a * c) | ||
| const denominator = 2 * a | ||
| let answer = '' | ||
| let answer = [] | ||
| if (discriminant >= 0) { |
There was a problem hiding this comment.
Please distinguish discriminant == 0 here to only add a single item to answer in that case.
appgurueu
reviewed
Oct 9, 2022
appgurueu
approved these changes
Oct 9, 2022
|
Please don't forget to rename the file. |
raklaptudirm
approved these changes
Oct 10, 2022
raklaptudirm
changed the title
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.