Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added program for infix to postfix conversion using stack #1192

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Harinath-B
Copy link

@Harinath-B Harinath-B commented Oct 15, 2022

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@lgtm-com
Copy link

lgtm-com bot commented Oct 15, 2022

This pull request introduces 1 alert when merging 4f50d07 into 8c847e3 - view on LGTM.com

new alerts:

  • 1 for Missing variable declaration

@Harinath-B Harinath-B closed this Oct 15, 2022
@Harinath-B Harinath-B reopened this Oct 15, 2022
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Fix your formatting. Please also use syntactical sugar like ++ or --.
  2. No side effects. Remove calls to console.log.

@Harinath-B Harinath-B closed this Oct 16, 2022
@Harinath-B Harinath-B reopened this Oct 16, 2022
@Harinath-B Harinath-B requested a review from appgurueu October 16, 2022 16:43
Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some more tests, with more descriptive test names

@Harinath-B Harinath-B closed this Oct 20, 2022
@Harinath-B Harinath-B reopened this Oct 20, 2022
@Harinath-B Harinath-B requested a review from appgurueu October 20, 2022 15:02
@@ -49,38 +49,32 @@ const isAlNum = (c) => {
}

const priority = (op) => {
op = String(op)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unnecessary.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still: Please add more complex tests. Testing one simple expression and the edge case of an empty expression is good but not enough.

@Harinath-B Harinath-B closed this Oct 22, 2022
@Harinath-B Harinath-B reopened this Oct 22, 2022
@@ -38,7 +38,7 @@ class Stack {
// Returns the last element without removing it
last () {
if (this.top !== -1) {
return this.stack[this.stack.length]
return this.stack[this.length()]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work with 0-indexing?

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants