-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added program for infix to postfix conversion using stack #1192
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 4f50d07 into 8c847e3 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix your formatting. Please also use syntactical sugar like
++
or--
. - No side effects. Remove calls to
console.log
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some more tests, with more descriptive test names
Data-Structures/Stack/ToPostfix.js
Outdated
@@ -49,38 +49,32 @@ const isAlNum = (c) => { | |||
} | |||
|
|||
const priority = (op) => { | |||
op = String(op) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unnecessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still: Please add more complex tests. Testing one simple expression and the edge case of an empty expression is good but not enough.
@@ -38,7 +38,7 @@ class Stack { | |||
// Returns the last element without removing it | |||
last () { | |||
if (this.top !== -1) { | |||
return this.stack[this.stack.length] | |||
return this.stack[this.length()] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work with 0-indexing?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Describe your change:
Checklist:
Example:
UserProfile.js
is allowed butuserprofile.js
,Userprofile.js
,user-Profile.js
,userProfile.js
are notFixes: #{$ISSUE_NO}
.