Two sum #1226
Open
Two sum #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appgurueu
reviewed
Oct 24, 2022
Data-Structures/Array/TwoSum.js
Outdated
| @@ -0,0 +1,24 @@ | |||
| // https://leetcode.com/problems/two-sum/ | |||
|
|
|||
| // Given an array of integers, return indices of the two numbers such that they add up to | |||
There was a problem hiding this comment.
Can you try to use a JSDoc comment right above the definition of TwoSum?
appgurueu
reviewed
Oct 24, 2022
| import { TwoSum } from '../TwoSum' | ||
|
|
||
| describe('TwoSum tests', () => { | ||
| it('check that a variety of inputs return the correct answer', () => { |
There was a problem hiding this comment.
Just use test("Two Sum", () => ...) right away
appgurueu
reviewed
Oct 24, 2022
| // Because nums[0] + nums[1] = 2 + 7 = 9, | ||
| // return [0, 1]. | ||
|
|
||
| const TwoSum = (nums, target) => { |
There was a problem hiding this comment.
That's a pretty naive implementation with a runtime of O(n²). Please document this in the JSDoc comment.
There was a problem hiding this comment.
Please see the docs and use the proper @annotations.
sandeepvinnu
approved these changes
Dec 3, 2022
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change:
Checklist:
Example:
UserProfile.jsis allowed butuserprofile.js,Userprofile.js,user-Profile.js,userProfile.jsare notFixes: #{$ISSUE_NO}.