Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the optimized solution for promblem 44 #1324

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

utkarsh-shrivastav77
Copy link

Optimised the solution for problem 44 in o(n) time complexity.

@utkarsh-shrivastav77
Copy link
Author

Sir please check the code let me know if there is any error

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing.

Please adapt the tests; they can't possibly work for this, since you renamed the function.

Second, the comments are very redundant with the code (and also read as if they had been written by a certain large language model). pentagonalIndices isn't a set of indices, it's a set of numbers.

I also don't see how this is supposed to be "O(n)" considering it has two nested for loops which I would assume to be O(n²) given that both for loops look like they are roughly O(k). What even is n?

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants