Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm-reduce problems on OS X #1441

Open
pepyakin opened this issue Feb 23, 2018 · 2 comments
Open

wasm-reduce problems on OS X #1441

pepyakin opened this issue Feb 23, 2018 · 2 comments

Comments

@pepyakin
Copy link
Contributor

Hi, check out my experience using wasm-reduce:

https://gist.github.com/pepyakin/79de4ac26d20adcd9db64bf85ef34cba

the problems I encountered:

  • timeout is not installed on macOS
  • wasm-opt can't be found without explicit env BINARYEN_ROOT.

I think that just a few more checks and error messages would be great to ease the experience!

@kripken
Copy link
Member

kripken commented Feb 23, 2018

Sorry, yeah, wasm-reduce is not very portable.

  • I don't know how to replace timeout in a portable way (maybe using threads?).
  • I'm also not sure how to fix the BINARYEN_ROOT issue, basically the executable needs to find another executable in the same dir as it, is there a way to do that in C++?

I agree it would be good to add checks with better error messages and suggestions in the meanwhile.

@pepyakin
Copy link
Contributor Author

Sorry, yeah, wasm-reduce is not very portable.

No worries, that's ok! : )

I don't know how to replace timeout in a portable way (maybe using threads?).

I think that might be possibe with pthread?

I'm also not sure how to fix the BINARYEN_ROOT issue, basically the executable needs to find another executable in the same dir as it, is there a way to do that in C++?

Maybe you can extract base-dir from an argv[0] and put it into a global variable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants