[Fix] Make overriding TLS verification optional #202
Conversation
Codecov Report
@@ Coverage Diff @@
## main #202 +/- ##
=======================================
Coverage 99.86% 99.86%
=======================================
Files 26 26
Lines 3721 3722 +1
=======================================
+ Hits 3716 3717 +1
Misses 5 5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Hi @aquamatthias, can you introduce a test case that covers the situation where verify_override is set to a boolean or a string? For example you could have an ArangoClient instantiation with a verify_override value set to a boolean/string and a for session in client._sessions ... assertion under test_client_attributes to ensure that coverage is not lost
We also have to keep in mind that the parameter name change (verify_certificate ➡️verify_override) will warrant a major version increase, as it is not backwards compatible
|
@aMahanna added tests for this behavior. The PR that introduced the argument was already breaking. |
Makes sense, |
|
Thank you! |
This PR allows overriding the TLS verification behavior.
It defaults to None and thus will have no effect if not explicitly defined.
If it is defined, it allows for enabling/disabling verification and defines a custom CA bundle file or directory as specified by the requests library.
Fixes #201