Clear cell cache when a dropdown/filter is selected

Completes and fixes 50d1e60

Author: facchinm

app/src/cc/arduino/contributions/libraries/ui/ContributedLibraryTableCellEditor.java

@@ -54,8 +54,6 @@
 @SuppressWarnings("serial")
 public class ContributedLibraryTableCellEditor extends InstallerTableCell {
 
-  private List<Component> cellList = new ArrayList<Component>();
-
   private ContributedLibraryReleases editorValue;
   private ContributedLibraryTableCellJPanel editorCell;
 
@@ -143,6 +141,15 @@ public Component getTableCellEditorComponent(JTable table, Object value,
 
     editorCell.setBackground(new Color(218, 227, 227)); // #dae3e3
 
+    if (cellList.size() < row) {
+      // allocate the empty slots
+      int i = cellList.size();
+      while (i < row) {
+        cellList.add(i, null);
+        i++;
+      }
+    }
+
     cellList.add(row, editorCell);
 
     return editorCell;

app/src/cc/arduino/contributions/packages/ui/ContributedPlatformTableCellEditor.java

@@ -52,8 +52,6 @@
 @SuppressWarnings("serial")
 public class ContributedPlatformTableCellEditor extends InstallerTableCell {
 
-  private List<Component> cellList = new ArrayList<Component>();
-
   private ContributedPlatformTableCellJPanel cell;
   private ContributedPlatformReleases value;
 
@@ -138,6 +136,14 @@ public Component getTableCellEditorComponent(JTable table, Object _value,
     cell.update(table, _value, true, !installedBuiltIn.isEmpty());
     cell.setBackground(new Color(218, 227, 227)); // #dae3e3
 
+    if (cellList.size() < row) {
+      // allocate the empty slots
+      int i = cellList.size();
+      while (i < row) {
+        cellList.add(i, null);
+        i++;
+      }
+    }
     cellList.add(row, cell);
 
     return cell;

app/src/cc/arduino/contributions/ui/InstallerJDialog.java

@@ -85,6 +85,7 @@ public abstract class InstallerJDialog<T> extends JDialog {
 
   // Real contribution table
   protected JTable contribTable;
+  private InstallerTableCell cellEditor;
   // Model behind the table
   protected final FilteredAbstractTableModel<T> contribModel;
   private final JButton closeButton;
@@ -125,6 +126,7 @@ protected void onFilter(String[] _filters) {
             contribTable.getCellEditor().stopCellEditing();
           }
           updateIndexFilter(filters, categoryFilter);
+          cellEditor.clearCache();
           if (contribModel.getRowCount() == 1) {
             // TODO: understand why it doesn't work
             //contribTable.addRowSelectionInterval(0, 0);
@@ -187,7 +189,8 @@ public void mouseMoved(MouseEvent e) {
       TableColumnModel tcm = contribTable.getColumnModel();
       TableColumn col = tcm.getColumn(0);
       col.setCellRenderer(createCellRenderer());
-      col.setCellEditor(createCellEditor());
+      cellEditor = createCellEditor();
+      col.setCellEditor(cellEditor);
       col.setResizable(true);
     }
 
@@ -260,6 +263,7 @@ public void mouseMoved(MouseEvent e) {
   public void updateIndexFilter(String[] filters, Predicate<T>... additionalFilters) {
     Stream<Predicate<T>> notNullAdditionalFilters = Stream.of(additionalFilters).filter(filter -> filter != null);
     contribModel.updateIndexFilter(filters, notNullAdditionalFilters);
+    cellEditor.clearCache();
   }
 
   public void setErrorMessage(String message) {
@@ -308,6 +312,7 @@ public void actionPerformed(ActionEvent event) {
           contribTable.getCellEditor().stopCellEditing();
         }
         updateIndexFilter(filters, categoryFilter);
+        cellEditor.clearCache();
       }
     }
   };

app/src/cc/arduino/contributions/ui/InstallerTableCell.java

@@ -29,8 +29,11 @@
 
 package cc.arduino.contributions.ui;
 
+import java.awt.Component;
 import java.awt.Dimension;
 import java.awt.Rectangle;
+import java.util.ArrayList;
+import java.util.List;
 
 import javax.swing.AbstractCellEditor;
 import javax.swing.JTextPane;
@@ -39,6 +42,8 @@
 
 public abstract class InstallerTableCell extends AbstractCellEditor implements TableCellEditor {
 
+  protected List<Component> cellList = new ArrayList<Component>();
+
   abstract public void setEnabled(boolean b);
 
   abstract public void setStatus(String s);
@@ -59,4 +64,8 @@ public static void setJTextPaneDimensionToFitContainedText(JTextPane jTextPane,
 
   }
 
+  public void clearCache() {
+    cellList.clear();
+  }
+
 }