Skip to content

Commit 7e7251d

Browse files
committedMar 8, 2019
Add watcher on sketch files
Reloads sketch content if the Editor is not in foreground and isomething happens in the backing storage files. Note that no confirmation dialog is displayed (same behaviour as SublimeText, differs from other IDEs) Fixes #4551 and #5345
1 parent fc9c1fe commit 7e7251d

File tree

3 files changed

+257
-5
lines changed

3 files changed

+257
-5
lines changed
 

‎app/src/processing/app/Editor.java

+44-3
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,15 @@
108108
import processing.app.tools.MenuScroller;
109109
import processing.app.tools.Tool;
110110

111+
import processing.app.tools.WatchDir;
112+
import static java.nio.file.StandardWatchEventKinds.*;
113+
import java.nio.file.WatchService;
114+
import java.nio.file.WatchKey;
115+
import java.nio.file.WatchEvent;
116+
import java.nio.file.FileSystems;
117+
import java.nio.file.Path;
118+
import java.io.File;
119+
111120
/**
112121
* Main editor panel for the Processing Development Environment.
113122
*/
@@ -122,6 +131,7 @@ public class Editor extends JFrame implements RunnerListener {
122131
private final Box upper;
123132
private ArrayList<EditorTab> tabs = new ArrayList<>();
124133
private int currentTabIndex = -1;
134+
private static boolean watcherDisable = false;
125135

126136
private static class ShouldSaveIfModified
127137
implements Predicate<SketchController> {
@@ -236,6 +246,8 @@ public boolean test(SketchController controller) {
236246
private Runnable timeoutUploadHandler;
237247

238248
private Map<String, Tool> internalToolCache = new HashMap<String, Tool>();
249+
protected Thread watcher = null;
250+
protected Runnable task = null;
239251

240252
public Editor(Base ibase, File file, int[] storedLocation, int[] defaultLocation, Platform platform) throws Exception {
241253
super("Arduino");
@@ -261,12 +273,20 @@ public void windowClosing(WindowEvent e) {
261273
// When bringing a window to front, let the Base know
262274
addWindowListener(new WindowAdapter() {
263275
public void windowActivated(WindowEvent e) {
276+
if (watcher != null) {
277+
watcher.interrupt();
278+
watcher = null;
279+
}
264280
base.handleActivated(Editor.this);
265281
}
266282

267283
// added for 1.0.5
268284
// http://dev.processing.org/bugs/show_bug.cgi?id=1260
269285
public void windowDeactivated(WindowEvent e) {
286+
if (watcher == null) {
287+
watcher = new Thread(task);
288+
watcher.start();
289+
}
270290
List<Component> toolsMenuItemsToRemove = new LinkedList<>();
271291
for (Component menuItem : toolsMenu.getMenuComponents()) {
272292
if (menuItem instanceof JComponent) {
@@ -381,7 +401,6 @@ public void windowDeactivated(WindowEvent e) {
381401
EditorConsole.setCurrentEditorConsole(console);
382402
}
383403

384-
385404
/**
386405
* Handles files dragged & dropped from the desktop and into the editor
387406
* window. Dragging files into the editor window is the same as using
@@ -1555,7 +1574,7 @@ public void reorderTabs() {
15551574
* the given file.
15561575
* @throws IOException
15571576
*/
1558-
protected void addTab(SketchFile file, String contents) throws IOException {
1577+
public synchronized void addTab(SketchFile file, String contents) throws IOException {
15591578
EditorTab tab = new EditorTab(this, file, contents);
15601579
tab.getTextArea().getDocument()
15611580
.addDocumentListener(new DocumentTextChangeListener(
@@ -1564,9 +1583,12 @@ protected void addTab(SketchFile file, String contents) throws IOException {
15641583
reorderTabs();
15651584
}
15661585

1567-
protected void removeTab(SketchFile file) throws IOException {
1586+
public synchronized void removeTab(SketchFile file) throws IOException {
15681587
int index = findTabIndex(file);
15691588
tabs.remove(index);
1589+
if (index == currentTabIndex) {
1590+
currentTabIndex = currentTabIndex -1;
1591+
}
15701592
}
15711593

15721594
// . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . . .
@@ -1842,6 +1864,25 @@ protected boolean handleOpenInternal(File sketchFile) {
18421864
// Disable untitled setting from previous document, if any
18431865
untitled = false;
18441866

1867+
if (watcherDisable == true) {
1868+
return true;
1869+
}
1870+
1871+
// Add FS watcher for current Editor instance
1872+
Path dir = file.toPath().getParent();
1873+
1874+
Editor instance = this;
1875+
1876+
task = new Runnable() {
1877+
public void run() {
1878+
try {
1879+
new WatchDir(dir, true).processEvents(instance);
1880+
} catch (IOException x) {
1881+
watcherDisable = true;
1882+
}
1883+
}
1884+
};
1885+
18451886
// opening was successful
18461887
return true;
18471888
}

‎app/src/processing/app/EditorTab.java

+15-2
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,14 @@
5050
import javax.swing.text.DefaultCaret;
5151
import javax.swing.text.Document;
5252

53+
import static java.nio.file.StandardWatchEventKinds.*;
54+
import java.nio.file.WatchService;
55+
import java.nio.file.WatchKey;
56+
import java.nio.file.WatchEvent;
57+
import java.nio.file.FileSystems;
58+
import java.nio.file.Path;
59+
import java.io.File;
60+
5361
import org.apache.commons.lang3.StringUtils;
5462
import org.fife.ui.rsyntaxtextarea.RSyntaxDocument;
5563
import org.fife.ui.rsyntaxtextarea.RSyntaxTextAreaEditorKit;
@@ -64,6 +72,7 @@
6472
import processing.app.syntax.SketchTextArea;
6573
import processing.app.syntax.SketchTextAreaEditorKit;
6674
import processing.app.tools.DiscourseFormat;
75+
import processing.app.tools.WatchDir;
6776

6877
/**
6978
* Single tab, editing a single file, in the main window.
@@ -110,7 +119,7 @@ public EditorTab(Editor editor, SketchFile file, String contents)
110119
file.setStorage(this);
111120
applyPreferences();
112121
add(scrollPane, BorderLayout.CENTER);
113-
textarea.addMouseWheelListener(this);
122+
textarea.addMouseWheelListener(this);
114123
}
115124

116125
private RSyntaxDocument createDocument(String contents) {
@@ -487,7 +496,11 @@ public void setSelection(int start, int stop) {
487496
public int getScrollPosition() {
488497
return scrollPane.getVerticalScrollBar().getValue();
489498
}
490-
499+
500+
public RTextScrollPane getScrollPane() {
501+
return scrollPane;
502+
}
503+
491504
public void setScrollPosition(int pos) {
492505
scrollPane.getVerticalScrollBar().setValue(pos);
493506
}
+198
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,198 @@
1+
/*
2+
* Copyright (c) 2008, 2010, Oracle and/or its affiliates. All rights reserved.
3+
*
4+
* Redistribution and use in source and binary forms, with or without
5+
* modification, are permitted provided that the following conditions
6+
* are met:
7+
*
8+
* - Redistributions of source code must retain the above copyright
9+
* notice, this list of conditions and the following disclaimer.
10+
*
11+
* - Redistributions in binary form must reproduce the above copyright
12+
* notice, this list of conditions and the following disclaimer in the
13+
* documentation and/or other materials provided with the distribution.
14+
*
15+
* - Neither the name of Oracle nor the names of its
16+
* contributors may be used to endorse or promote products derived
17+
* from this software without specific prior written permission.
18+
*
19+
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS
20+
* IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
21+
* THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
22+
* PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
23+
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
24+
* EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
25+
* PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
26+
* PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF
27+
* LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
28+
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
29+
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
30+
*/
31+
32+
package processing.app.tools;
33+
34+
import java.nio.file.*;
35+
import static java.nio.file.StandardWatchEventKinds.*;
36+
import static java.nio.file.LinkOption.*;
37+
import java.nio.file.attribute.*;
38+
import java.io.*;
39+
import java.util.*;
40+
import processing.app.Editor;
41+
import processing.app.EditorTab;
42+
import processing.app.Sketch;
43+
import processing.app.SketchFile;
44+
import processing.app.helpers.FileUtils;
45+
46+
/**
47+
* Example to watch a directory (or tree) for changes to files.
48+
*/
49+
50+
public class WatchDir {
51+
52+
private final WatchService watcher;
53+
private final Map<WatchKey,Path> keys;
54+
private final boolean recursive;
55+
private boolean trace = false;
56+
57+
@SuppressWarnings("unchecked")
58+
static <T> WatchEvent<T> cast(WatchEvent<?> event) {
59+
return (WatchEvent<T>)event;
60+
}
61+
62+
/**
63+
* Register the given directory with the WatchService
64+
*/
65+
private void register(Path dir) throws IOException {
66+
WatchKey key = dir.register(watcher, ENTRY_CREATE, ENTRY_DELETE, ENTRY_MODIFY);
67+
if (trace) {
68+
Path prev = keys.get(key);
69+
if (prev == null) {
70+
} else {
71+
if (!dir.equals(prev)) {
72+
}
73+
}
74+
}
75+
keys.put(key, dir);
76+
}
77+
78+
/**
79+
* Register the given directory, and all its sub-directories, with the
80+
* WatchService.
81+
*/
82+
private void registerAll(final Path start) throws IOException {
83+
// register directory and sub-directories
84+
Files.walkFileTree(start, new SimpleFileVisitor<Path>() {
85+
@Override
86+
public FileVisitResult preVisitDirectory(Path dir, BasicFileAttributes attrs)
87+
throws IOException
88+
{
89+
register(dir);
90+
return FileVisitResult.CONTINUE;
91+
}
92+
});
93+
}
94+
95+
/**
96+
* Creates a WatchService and registers the given directory
97+
*/
98+
public WatchDir(Path dir, boolean recursive) throws IOException {
99+
this.watcher = FileSystems.getDefault().newWatchService();
100+
this.keys = new HashMap<WatchKey,Path>();
101+
this.recursive = recursive;
102+
103+
if (recursive) {
104+
registerAll(dir);
105+
} else {
106+
register(dir);
107+
}
108+
109+
// enable trace after initial registration
110+
this.trace = true;
111+
}
112+
113+
/**
114+
* Process all events for keys queued to the watcher
115+
*/
116+
public void processEvents(Editor editor) {
117+
for (;;) {
118+
119+
// wait for key to be signalled
120+
WatchKey key;
121+
try {
122+
key = watcher.take();
123+
} catch (InterruptedException x) {
124+
return;
125+
}
126+
127+
Path dir = keys.get(key);
128+
if (dir == null) {
129+
continue;
130+
}
131+
132+
for (WatchEvent<?> event: key.pollEvents()) {
133+
WatchEvent.Kind kind = event.kind();
134+
135+
// TBD - provide example of how OVERFLOW event is handled
136+
if (kind == OVERFLOW) {
137+
continue;
138+
}
139+
140+
// Context for directory entry event is the file name of entry
141+
WatchEvent<Path> ev = cast(event);
142+
Path name = ev.context();
143+
Path child = dir.resolve(name);
144+
145+
// reload the tab content
146+
if (kind == ENTRY_CREATE) {
147+
try {
148+
String filename = name.toString();
149+
FileUtils.SplitFile split = FileUtils.splitFilename(filename);
150+
if (Sketch.EXTENSIONS.contains(split.extension.toLowerCase())) {
151+
SketchFile sketch = editor.getSketch().addFile(filename);
152+
editor.addTab(sketch, null);
153+
}
154+
} catch (Exception e) {
155+
return;
156+
}
157+
} else if (kind == ENTRY_DELETE) {
158+
try {
159+
Thread.sleep(100);
160+
int index = editor.getSketch().findFileIndex(child.toAbsolutePath().toFile());
161+
editor.removeTab(editor.getSketch().getFile(index));
162+
} catch (Exception e1) {
163+
// Totally fine, if the sleep gets interrupted it means that
164+
// the action was executed in the UI, not externally
165+
return;
166+
}
167+
}
168+
editor.getTabs().forEach(tab -> {
169+
if (!tab.isModified()) {
170+
tab.reload();
171+
}
172+
});
173+
// if directory is created, and watching recursively, then
174+
// register it and its sub-directories
175+
if (recursive && (kind == ENTRY_CREATE)) {
176+
try {
177+
if (Files.isDirectory(child, NOFOLLOW_LINKS)) {
178+
registerAll(child);
179+
}
180+
} catch (IOException x) {
181+
// ignore to keep sample readbale
182+
}
183+
}
184+
}
185+
186+
// reset key and remove from set if directory no longer accessible
187+
boolean valid = key.reset();
188+
if (!valid) {
189+
keys.remove(key);
190+
191+
// all directories are inaccessible
192+
if (keys.isEmpty()) {
193+
break;
194+
}
195+
}
196+
}
197+
}
198+
}

0 commit comments

Comments
 (0)
Failed to load comments.