-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add watcher on sketch files #6074
base: master
Are you sure you want to change the base?
Conversation
What about handling deletion of secondary sketch files (AKA "tabs") outside the IDE? If I delete one outside the IDE when using this test build 664 I get:
If the watcher removed tabs that were deleted outside the IDE it would help fix #2072. |
Reloads sketch content if the Editor is not in foreground and isomething happens in the backing storage files. Note that no confirmation dialog is displayed (same behaviour as SublimeText, differs from other IDEs) Fixes arduino#4551 and arduino#5345
✅ Build completed. Please test this code using one of the following: ⬇️ http://downloads.arduino.cc/javaide/pull_requests/arduino-PR-6074-BUILD-704-linux32.tar.xz ℹ️ The |
It seems to work, unless I have unsaved changes in the Arduino IDE. That is, for "clean" files (all changes saved) it detects the external changes, but not for "dirty" files (with unsaved changes in the Arduino IDE). |
Reloads sketch content if the Editor is not in foreground and something happens in the backing storage files.
Note that no confirmation dialog is displayed (same behaviour as SublimeText, differs from other IDEs)
Fixes #4551 and #5345
ONLY TESTED ON LINUX with
/proc/sys/fs/inotify/max_user_watches
= 524288