Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] Should measurements be stored in Secrets Manager? #32

Closed
jplock opened this issue Sep 20, 2024 · 0 comments · Fixed by #40
Closed

[fix] Should measurements be stored in Secrets Manager? #32

jplock opened this issue Sep 20, 2024 · 0 comments · Fixed by #40
Assignees
@jplock
Labels
question Further information is requested

Comments

@jplock
Copy link
Contributor

jplock commented Sep 20, 2024

I'm wondering if we should store the measurements in an Secrets Manager secret instead of S3.

Thoughts

  • We would be able to control who is allowed to update the secret (CodeBuild) and get the secret value (StepFunctions)
  • Wouldn't need to worry about who has access to build artifacts in the S3 bucket
@jplock jplock added the question Further information is requested label Sep 20, 2024
@jplock jplock self-assigned this Sep 20, 2024
@jplock jplock mentioned this issue Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jplock jplock

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
1 participant
@jplock