Enhance prod minification #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added postcss-csso for css/scss minification Added DEV_SERVER_HOST_URL directly in .env (dev server under subdomain support)
|
Thanks for this, will review over the weekend. |
added 2 commits
December 9, 2017 01:24
calvinl
reviewed
Dec 11, 2017
package.json
Outdated
| @@ -124,16 +125,19 @@ | |||
| "redbox-react": "^1.5.0", | |||
| "supertest": "^3.0.0", | |||
| "webpack-dev-server": "^2.9.6", | |||
calvinl
reviewed
Dec 11, 2017
package.json
Outdated
| @@ -124,16 +125,19 @@ | |||
| "redbox-react": "^1.5.0", | |||
| "supertest": "^3.0.0", | |||
| "webpack-dev-server": "^2.9.6", | |||
| "webpack-dev-server": "^2.9.7", | |||
| "webpack-sources": "^1.1.0" | |||
| }, | |||
| "dependencies": { | |||
| "app-module-path": "^2.2.0", | |||
| "autoprefixer": "^7.2.1", | |||
calvinl
reviewed
Dec 11, 2017
package.json
Outdated
| "webpack-sources": "^1.1.0" | ||
| }, | ||
| "dependencies": { | ||
| "app-module-path": "^2.2.0", | ||
| "autoprefixer": "^7.2.1", | ||
| "autoprefixer": "^7.2.2", | ||
| "axios": "^0.17.1", | ||
| "babel": "^6.23.0", | ||
| "babel-cli": "^6.26.0", | ||
| "babel-core": "^6.26.0", | ||
| "babel-loader": "^7.1.1", |
There was a problem hiding this comment.
And this. :)
Please also commit package-lock.json
calvinl
reviewed
Dec 11, 2017
postcss.config.js
Outdated
| @@ -1,5 +1,10 @@ | |||
| const autoprefixer = require('autoprefixer'); | |||
| const csso = require('postcss-csso')({restructure: true, comments: false}); | |||
There was a problem hiding this comment.
style should have spacing between curly braces, e.g.
{restructure: true, comments: false}
to
{ restructure: true, comments: false }
calvinl
reviewed
Dec 11, 2017
webpack/production.babel.js
Outdated
|
|
||
| // the clean options to use | ||
| let cleanOptions = { | ||
| root: '/var/www/react/', |
There was a problem hiding this comment.
Wouldn't __dirname be better here?
calvinl
reviewed
Dec 11, 2017
webpack/production.babel.js
Outdated
| @@ -1,19 +1,39 @@ | |||
| import webpack from 'webpack'; | |||
| import baseConfig from './base'; | |||
| import CompressionPlugin from 'compression-webpack-plugin'; | |||
| import CleanWebpackPlugin from 'clean-webpack-plugin'; | |||
There was a problem hiding this comment.
In production, this package is missing. Please add to package.json.
calvinl
reviewed
Dec 11, 2017
server/server.js
Outdated
| @@ -33,7 +33,7 @@ app.use(compression()); | |||
|
|
|||
| // Add middleware to serve up all static files | |||
| app.use('/dist', | |||
| express.static(path.join(__dirname, '../dist')), | |||
| express.static(path.join(__dirname, '../dist/public')), | |||
There was a problem hiding this comment.
let's use process.env.WEBPACK_OUTPUT_PATH here instead.
calvinl
reviewed
Dec 11, 2017
|
Yeah i made few mistakes with my PR I update these |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added postcss-csso for css/scss minification
Added DEV_SERVER_HOST_URL directly in .env (dev server under subdomain support)