Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc owners column to area owners table #60818

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Mar 7, 2025

Add doc owners column to area owners table #60818

CoPilot made the changes.

Use
image

Once this merges we can start filling out the doc-owners column.

cc @guardrex

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Added doc-owners column

Description

{Detail}

Fixes #{bug number} (in this specific format)

@Copilot Copilot bot review requested due to automatic review settings March 7, 2025 23:20
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This pull request adds a "Doc Owners" column to the area owners table in the documentation. The update modifies the table header to include the new column and adjusts all table rows (both for existing area entries and other repos) by adding an empty cell for "Doc Owners".

Reviewed Changes

File Description
docs/area-owners.md Updated table header and all rows to include a "Doc Owners" column.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

docs/area-owners.md:5

  • [nitpick] The new 'Doc Owners' column is added without any placeholder values, which might be confusing for readers. Consider adding a default value (e.g., 'N/A') in rows where no doc owner is provided.
| area label | Owners | Doc Owners | Description
@danmoseley
Copy link
Member

@Rick-Anderson great idea, do you want to add the writers in then? Maybe you didn't push that commit yet?

BTW, once this is done, might be worth doing https://github.com/dotnet/runtime/blob/main/docs/area-owners.md as well (either a column or a note in there)

@Rick-Anderson
Copy link
Contributor Author

@Rick-Anderson great idea, do you want to add the writers in then? Maybe you didn't push that commit yet?

Owners Added. Can you S&M?

This will change in a couple months when @tdykstra returns

BTW, once this is done, might be worth doing https://github.com/dotnet/runtime/blob/main/docs/area-owners.md as well (either a column or a note in there)

I've asked the .NET team to do that. cc @BillWagner @IEvangelist

@danmoseley danmoseley enabled auto-merge (squash) March 17, 2025 16:14
@danmoseley danmoseley disabled auto-merge March 17, 2025 16:18
@danmoseley danmoseley merged commit 00e50da into main Mar 17, 2025
20 of 23 checks passed
@danmoseley danmoseley deleted the Rick-Anderson-patch-1 branch March 17, 2025 16:18
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants