Add NotFoundPage to Router
#60970
Open
Add NotFoundPage to Router
#60970
+162
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
area-blazor
javiercn
reviewed
Mar 17, 2025
javiercn
reviewed
Mar 17, 2025
src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.EventDispatch.cs
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Mar 17, 2025
javiercn
reviewed
Mar 17, 2025
src/Components/test/testassets/Components.WasmMinimal/Routes.razor
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Mar 18, 2025
There was a problem hiding this comment.
Looks great!
I think we will also want to update the project templates to use this feature.
In addition to it, I think there's another scenario we want to enable here which is to make sure that it works with UseStatusCodeWithReexecute
UseStatusCodeWithReexecuteallows the app to render a page after a 404 has been set somewhere. We want that to also be possible with a Component page
I did something similar for handling errors a couple releases back. This is the PR with the change for reference #50550
- I suspect we will need to do something similar here.
/cc: @danroth27
3 tasks
ilonatommy
commented
Mar 21, 2025
| @@ -0,0 +1,34 @@ | |||
| @ECHO OFF | |||
There was a problem hiding this comment.
This is an improvement in testing templates and a bit that I was missing to debug the results of *Locally scripts. It could be a separate PR if really needed.
ilonatommy
commented
Mar 21, 2025
...ectTemplates/content/BlazorWeb-CSharp/BlazorWeb-CSharp/Components/Pages/WeatherDetails.razor
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NotFoundPageparameter that can be used to customize the view of page rendered onNotFoundEvent.Fixes #58815