Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass InnerBuildArgs to inner RepoTasks build in SourceBuild #61020

Merged
merged 1 commit into from
Mar 19, 2025
Merged

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Mar 19, 2025

As identified in dotnet/sdk#46898

@wtgodbe wtgodbe requested a review from a team as a code owner March 19, 2025 17:15
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 19, 2025
Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will see if that works or not ;)

@wtgodbe wtgodbe merged commit 667b514 into main Mar 19, 2025
27 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/IBA branch March 19, 2025 19:17
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview4 milestone Mar 19, 2025
@ViktorHofer
Copy link
Member

That one didn't work because the property isn't yet set when it is read. I submitted dotnet/dotnet#165 to see if this works. I fear that the additional /bl:... command will conflict with the other binlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants