Runs for specified models only

Author: dsalahutdinov

.rubocop.yml

@@ -16,3 +16,6 @@ Metrics/LineLength:
 Metrics/BlockLength:
   Exclude:
    - 'spec/**/*'
+
+RSpec/MultipleExpectations:
+  Max: 3

README.md

@@ -31,10 +31,14 @@ Accordance/TablePresence: Stat::Hourly has no underlying table hourly_stats
 
 ## Options
 
-Check only specified database rules:
+Check only specified database rules with `--only` options:
 ```
   bundle exec data_integrity --only HasMany/ForeignKey,BelongsTo/ForeignKey
 ```
+Check only specified model with the list of the model full with:
+```sh
+  bundle exec data_integrity --only HasMany/ForeignKye Billing::Account User
+```
 
 ## Supported Issues
 

lib/active_record/data_integrity/cli.rb

@@ -1,25 +1,24 @@
 # frozen_string_literal: true
 
 require 'thor'
-require_relative 'options'
+require_relative 'config'
 
 module ActiveRecord
   module DataIntegrity
     # CLI application class
     class CLI < Thor
-      attr_reader :options
-
-      desc 'check [OPTIONS]', 'Runs the data integrity check'
+      desc 'check [OPTIONS] [MODEL_NAMES]', 'Runs the data integrity check'
       method_option :only,
                     type: :string,
                     desc: 'List of the rules to check, separated with comma' \
                           ', e.g. --only BelongsTo/ForeignKey,Accordance/PrimaryKey'
-      def check(_args = ARGV)
-        @options = Options.new(options)
+      def check(*model_names)
+        config = Config.new(options.merge(model_names: model_names))
+
         require_rails
 
-        results = cops.map do |cop_class|
-          ActiveRecord::Base.descendants.each do |model|
+        results = config.cops.map do |cop_class|
+          config.models.each do |model|
             cop_class.new(model).call
           end
         end
@@ -38,14 +37,6 @@ def version
 
       private
 
-      def cops
-        @cops ||= begin
-          ActiveRecord::DataIntegrity::Cop.descendants.select do |cop|
-            options.only.empty? || cop.cop_name.in?(options.only)
-          end
-        end
-      end
-
       def require_rails
         # Rails load ugly hack :)
         require File.expand_path('config/environment', Dir.pwd)

lib/active_record/data_integrity/config.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+require 'optparse'
+
+module ActiveRecord
+  module DataIntegrity
+    # Config  parser
+    class Config
+      attr_reader :only, :model_names
+
+      def initialize(options)
+        @only = options.only? ? options.only.to_s.split(',') : []
+        @model_names = options.model_names || []
+      end
+
+      def cops
+        @cops ||= begin
+          ActiveRecord::DataIntegrity::Cop.descendants.select do |cop|
+            only.empty? || cop.cop_name.in?(only)
+          end
+        end
+      end
+
+      def models
+        @models ||= begin
+          ActiveRecord::Base.descendants.select do |model|
+            model_names.empty? || model.name.in?(model_names)
+          end
+        end
+      end
+    end
+  end
+end

lib/active_record/data_integrity/options.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe ActiveRecord::DataIntegrity::Config do
+  let(:options) { Thor::CoreExt::HashWithIndifferentAccess.new }
+  let(:config) { described_class.new(options) }
+
+  before { ActiveRecord::Base.connection }
+
+  describe '#cops' do
+    context 'when option only is passed' do
+      before { options[:only] = 'HasMany/ForeignKey' }
+
+      it do
+        expect(config.cops).to include(ActiveRecord::DataIntegrity::HasMany::ForeignKey)
+        expect(config.cops).not_to include(ActiveRecord::DataIntegrity::BelongsTo::ForeignKey)
+      end
+    end
+
+    context 'when option only is not passed' do
+      it do
+        expect(config.cops).to include(ActiveRecord::DataIntegrity::HasMany::ForeignKey)
+        expect(config.cops).to include(ActiveRecord::DataIntegrity::BelongsTo::ForeignKey)
+      end
+    end
+  end
+
+  describe '#models' do
+    before { BelongsTo::User && BelongsTo::UserSetting }
+
+    context 'when option model_names is passed' do
+      before { options[:model_names] = ['BelongsTo::User'] }
+
+      it do
+        expect(config.models).to include(BelongsTo::User)
+        expect(config.models).not_to include(BelongsTo::UserSetting)
+      end
+    end
+
+    context 'when option model_names is not passed' do
+      it do
+        expect(config.models).to include(BelongsTo::User)
+        expect(config.models).to include(BelongsTo::UserSetting)
+      end
+    end
+  end
+end