Fix STACK_OVERFLOW_CHECK (ASSERTIONS=2) + dynamic linking (#13062)

Because the stack bounds are stored per-module wasm globals
we need to call `__set_stack_limits` for each module.

See: #13040

Author: sbc100

src/library_dylink.js

@@ -61,13 +61,23 @@ var LibraryDylink = {
     }
   },
 
-  $updateGOT__deps: ['$GOT'],
+  $isInternalSym: function(symName) {
+    // TODO: find a way to mark these in the binary or avoid exporting them.
+    return [
+      '__cpp_exception',
+      '__wasm_apply_data_relocs',
+      '__dso_handle',
+      '__set_stack_limits'
+    ].indexOf(symName) != -1;
+  },
+
+  $updateGOT__deps: ['$GOT', '$isInternalSym'],
   $updateGOT: function(exports) {
 #if DYLINK_DEBUG
     err("updateGOT: " + Object.keys(exports).length);
 #endif
     for (var symName in exports) {
-      if (symName == '__cpp_exception' || symName == '__dso_handle' || symName == '__wasm_apply_relocs') {
+      if (isInternalSym(symName)) {
         continue;
       }
 
@@ -410,6 +420,10 @@ var LibraryDylink = {
         if (!flags.allowUndefined) {
           reportUndefinedSymbols();
         }
+#if STACK_OVERFLOW_CHECK >= 2
+
+        moduleExports['__set_stack_limits'](_emscripten_stack_get_base(), _emscripten_stack_get_end());
+#endif
         // initialize the module
         var init = moduleExports['__post_instantiate'];
         if (init) {
@@ -468,7 +482,7 @@ var LibraryDylink = {
   // If a library was already loaded, it is not loaded a second time. However
   // flags.global and flags.nodelete are handled every time a load request is made.
   // Once a library becomes "global" or "nodelete", it cannot be removed or unloaded.
-  $loadDynamicLibrary__deps: ['$LDSO', '$loadWebAssemblyModule', '$asmjsMangle', '$fetchBinary'],
+  $loadDynamicLibrary__deps: ['$LDSO', '$loadWebAssemblyModule', '$asmjsMangle', '$fetchBinary', '$isInternalSym'],
   $loadDynamicLibrary: function(lib, flags) {
     if (lib == '__main__' && !LDSO.loadedLibNames[lib]) {
       LDSO.loadedLibs[-1] = {
@@ -577,7 +591,7 @@ var LibraryDylink = {
         else {
           var curr = Module[sym], next = libModule[sym];
           // don't warn on functions - might be odr, linkonce_odr, etc.
-          if (!(typeof curr === 'function' && typeof next === 'function')) {
+          if (!(typeof curr === 'function' && typeof next === 'function') && !isInternalSym(sym)) {
             err("warning: symbol '" + sym + "' from '" + lib + "' already exists (duplicate symbol? or weak linking, which isn't supported yet?)");
           }
         }

src/preamble.js

@@ -381,7 +381,7 @@ function initRuntime() {
 #endif
   runtimeInitialized = true;
 #if STACK_OVERFLOW_CHECK >= 2
-  Module['___set_stack_limits'](_emscripten_stack_get_base(), _emscripten_stack_get_end());
+  ___set_stack_limits(_emscripten_stack_get_base(), _emscripten_stack_get_end());
 #endif
   {{{ getQuoted('ATINITS') }}}
   callRuntimeCallbacks(__ATINIT__);

tests/test_core.py

@@ -3809,13 +3809,13 @@ def test():
       ''', expected=['new main\nnew side\n', 'new side\nnew main\n'])
     test()
 
+    print('check warnings')
+    self.set_setting('ASSERTIONS', 2)
+    test()
+    self.run_js('src.js')
     # TODO: this in wasm
-    if self.get_setting('ASSERTIONS') == 1 and not self.is_wasm():
-      print('check warnings')
-      self.set_setting('ASSERTIONS', 2)
-      test()
-      full = self.run_js('src.js')
-      self.assertNotContained("trying to dynamically load symbol '__ZN5ClassC2EPKc' (from 'liblib.so') that already exists", full)
+    # full = self.run_js('src.js')
+    # self.assertNotContained('already exists', full)
 
   @needs_dlfcn
   def test_dylink_i64(self):