-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Support uuid_generate_random (in uuid/uuid.h) #12093
Comments
From the docs I think it would be acceptable to alias those (one may be more secure, but it doesn't have to be; also it looks like we do try to be as secure as possible already). A PR adding an alias would be welcome! It could basically be a single line |
Should it be sth like: uuid_generate_random: function(u) {return this.uuid_generate(u);} ? |
You wouldn't use But in the simple case where it's just an alias - so it just calls the other function, with the param, and returns the result, as you wrote - then A PR would be great! |
I created a PR with this proposed fix, but haven't tested it locally at all :( |
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
stale bump |
bump |
The PR is open here #12430. We just asked for test to be written. Maybe you want to take a stab at it? |
This makes fontconfig compilation fail and was also noted in dotnet/corert#4624
Maybe an unsecure hack (behind an emcc option?) aliasing uuid_generate as uuid_generate_random could be provided?
Currently I patch it out with a define:
CFLAGS=-Duuid_generate_random=uuid_generate
The text was updated successfully, but these errors were encountered: