Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return code from sendto, etc handled incorrectly in websocket_to_posix_proxy #16897

Open
glennra opened this issue May 6, 2022 · 2 comments · May be fixed by #16925
Open

Return code from sendto, etc handled incorrectly in websocket_to_posix_proxy #16897

glennra opened this issue May 6, 2022 · 2 comments · May be fixed by #16925

Comments

@glennra
Copy link

glennra commented May 6, 2022 •
edited
Loading

The return code from sendto() and recvfrom() is the number of bytes sent or -1 for an error so the check for an error here should be ret<0, not ret!=0

emscripten/tools/websocket_to_posix_proxy/src/websocket_to_posix_proxy.c

Line 1217 in 8373cfa

errorCode = (ret != 0) ? GET_SOCKET_ERROR() : 0;

emscripten/tools/websocket_to_posix_proxy/src/websocket_to_posix_proxy.c

Line 1259 in 8373cfa

errorCode = (ret != 0) ? GET_SOCKET_ERROR() : 0;

@kripken
Copy link
Member

kripken commented May 6, 2022

cc @juj

juj added a commit to juj/emscripten that referenced this issue May 10, 2022
@juj
On Linux/BSD/macOS, socket API calls return -1 on failure (typically …
e4f75c6 
…tested against via if (ret < 0)). On Windows, Win32 API docs ask to check against SOCKET_ERROR and/or INVALID_SOCKET values, depending on API call in question. Fix bad error checks against value of zero and instead use checks that reflect the best practices on both platforms. Fixes emscripten-core#16897.
@juj juj linked a pull request May 10, 2022 that will close this issue
Open
@juj
Copy link
Collaborator

juj commented May 10, 2022

Great observation @glennra , thanks for filing! Fix PR in #16925.

juj added a commit to juj/emscripten that referenced this issue Mar 6, 2023
@juj
On Linux/BSD/macOS, socket API calls return -1 on failure (typically …
102e6bd 
…tested against via if (ret < 0)). On Windows, Win32 API docs ask to check against SOCKET_ERROR and/or INVALID_SOCKET values, depending on API call in question. Fix bad error checks against value of zero and instead use checks that reflect the best practices on both platforms. Fixes emscripten-core#16897.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix websocket_to_posix_proxy API call error checks juj/emscripten
3 participants
@kripken @juj @glennra