Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a test for #11880, for after it is fixed [ci skip] #11881

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kripken
Copy link
Member

@kripken kripken commented Aug 12, 2020

This test would have noticed the regression.

@kripken
Copy link
Member Author

kripken commented Aug 12, 2020

Unfortunately, this would require building libc-mt for LTO, which we haven't yet. Not sure it's worth it just for one test..?

Base automatically changed from master to main March 8, 2021 23:49
@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Apr 16, 2022
@sbc100
Copy link
Collaborator

sbc100 commented Apr 28, 2022

I think its probably worth adding this test and add libc-mt LTO to the core set of libraries.

@stale stale bot removed the wontfix label Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants