Document pthread ordering of sync/async commands [ci skip] #12546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
juj
reviewed
Nov 10, 2020
| @@ -310,6 +310,11 @@ int emscripten_sync_run_in_main_runtime_thread_(EM_FUNC_SIGNATURE sig, void *fun | |||
| // - Note that multiple asynchronous commands from a single pthread/Worker are | |||
| // guaranteed to be executed on the main thread in the program order they | |||
| // were called in. | |||
| // - Note that synchronous and asynchronous commands are *also* guaranteed to | |||
| // be executed in order. That is, sync and async commands cannot be | |||
| // reordered. The only difference between a sync and async command is that | |||
There was a problem hiding this comment.
Maybe instead That is, sync and async commands will not get reordered in the queue, but will be executed in the sequentially consistent order in which they were dispatched.?, because "cannot be reordered" can be read a bit vaguely: Who cannot reorder them? Can I not reorder sync and async commands? Why not?
There was a problem hiding this comment.
Sounds good, thanks, updated.
juj
approved these changes
Nov 10, 2020
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.