Add thread local storage support for dynamic libraries #13447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into dylink-pthread-tls
…into dylink-pthread-tls
|
I'm not sure why the circleci checks haven't run. They seem to have run fine on my fork. |
…into dylink-pthread-tls
…into dylink-pthread-tls
sbc100
added a commit
that referenced
this pull request
Feb 16, 2022
The remaining issue with exception with this combination of features was fixed by this upstream llvm change: https://reviews.llvm.org/D119630 Fixes: #13398, #13447
sbc100
added a commit
that referenced
this pull request
Feb 16, 2022
The remaining issue with exception with this combination of features was fixed by this upstream llvm change: https://reviews.llvm.org/D119630 Fixes: #13398, #13447
sbc100
added a commit
that referenced
this pull request
Feb 16, 2022
The remaining issue with exception with this combination of features was fixed by this upstream llvm change: https://reviews.llvm.org/D119630 Fixes: #13398, #13447
sbc100
added a commit
that referenced
this pull request
Feb 17, 2022
The remaining issue with exceptions and this combination of features were fixed by https://reviews.llvm.org/D119630 and https://reviews.llvm.org/D119666. Fixes: #13398, #13447
sbc100
added a commit
that referenced
this pull request
Feb 17, 2022
The remaining issue with exceptions and this combination of features were fixed by https://reviews.llvm.org/D119630 and https://reviews.llvm.org/D119666. Fixes: #13398, #13447
|
These issues that this PR was trying to address should all not be fixed. I finally landed and end-to-end test here: #16314. So I think this PR can be closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13398
Currently TLS in side modules is left uninitialized. TLS is required (among other things) to correctly handle exception in side modules.
To initialize TLS the side module needs to link against
emscripten_tls_init.cIn the main thread, this will be called by
__post_instantiate. This is the same behavior as for the main module.In secondary threads TLS should be manually initialized by explicitly calling
emscripten_tls_init. This is the same behavior as for the main module.In optimized builds, symbols required by
emscripten_tls_init(those areemscripten_builtin_memalignandpthread_cleanup_push) might be eliminated by DCE if the main module doesn't need them, so they need to be explicitly kept alive.Currently
__post_instantiateis incorrectly being called in secondary threads. This should be fixed by PR #13395. Without that PR, TLS would be initialized twice (harmless but incorrect).For exceptions to work it should also link against
emscripten_exception_builtins.c. Exceptions handling generate code that assume the library is linked agains it.