make sensible choice in default setting #13449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by default emscripten will catch non-fatal errors in OTHER PARTS OF THE appliction, and THROW IN THE TOWEL and crash!! it's like Mike Tyson hitting the floor after getting first punch!!! cost me several server crashes that would have been HANDLED ELSEWHER.
|
Thank you for submitting a pull request! If this is your first PR, make sure to add yourself to AUTHORS. |
|
I agree it would be good to change the default here. But as a first step, we need to investigate those test failures. We also need to check that changing the default would not reduce any test coverage (that we'd miss any errors), but I think that is not a problem. |
|
This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default emscripten will catch non-fatal errors in OTHER PARTS OF THE appliction, and THROW IN THE TOWEL and crash!!
it's like Mike Tyson hitting the floor after getting first punch!!! cost me several server crashes that would have been HANDLED ELSEWHER.