Add test for phthreads + dylink + exceptions #16314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
pthread_dylink_exceptions
branch
2 times, most recently
from
0f43328 to
70451b6
Compare
kripken
approved these changes
Feb 16, 2022
|
Ooops, it looks like we still need to land https://reviews.llvm.org/D119666 before this change can land. |
The remaining issue with exceptions and this combination of features were fixed by https://reviews.llvm.org/D119630 and https://reviews.llvm.org/D119666. Fixes: #13398, #13447
sbc100
force-pushed
the
pthread_dylink_exceptions
branch
from
70451b6 to
e16db3a
Compare
|
I also confirmed this runs with Wasm EH on Node 17.5. (Node 16.9 doesn't work.) But our node is even lower than that, so I can't add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The remaining issue with exception with this combination of features
was fixed by both https://reviews.llvm.org/D119630 and
https://reviews.llvm.org/D119666.
Fixes: #13398, #13447