Closes #16176 : Making writeStackCookie() to use HEAPU32 #16433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the makeSetValue() function to accept unsigned as a bool parameter, and based on this bool value decide the type of HEAP(HEAP32/HEAPU32).
sbc100
reviewed
Mar 6, 2022
| * @param {bool} ignore: legacy, ignored. | ||
| * @param {number} align: TODO | ||
| * @param {bool} noSafe: TODO | ||
| * @param {string} sep: TODO | ||
| * @param {bool} forcedAlign: legacy, ignored. | ||
| * @return {TODO} | ||
| */ | ||
| function makeSetValue(ptr, pos, value, type, noNeedFirst, ignore, align, noSafe, sep = ';', forcedAlign) { | ||
| function makeSetValue(ptr, pos, value, type, noNeedFirst, unsigned, ignore, align, noSafe, sep = ';', forcedAlign) { |
There was a problem hiding this comment.
Add a new argument in this position will bread existing callers.
I'd rather not add complexity to makeSetValue by adding another argument here.
There was a problem hiding this comment.
(also I'm curious why this was never needed before... how is it that all of the makeSetValue calls works just fine without ever using the unsigned heaps..).
sbc100
reviewed
Mar 6, 2022
| {{{ makeSetValue('max', 0, '0x2135467', 'i32' ) }}}; | ||
| {{{ makeSetValue('max', 4, '0x89BACDFE', 'i32' ) }}}; | ||
| {{{ makeSetValue('max', 0, '0x2135467', 'i32', 0, true) }}}; | ||
| {{{ makeSetValue('max', 4, '0x89BACDFE', 'i32', 0, true) }}}; |
There was a problem hiding this comment.
How about instead we just change these lines to:
HEAPU32[(max >> 2)] = 0x2135467
HEAPU32[(max >> 2) + 1] = 0x89BACDFE
(also the line below would need updating too).
There was a problem hiding this comment.
even better you can do:
var max = _emscripten_stack_get_end() >> 2;
HEAPU32[max] = 0x2135467;
HEAPU32[max + 1] = 0x89BACDFE;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made the makeSetValue() function to accept unsigned as a bool parameter,
and based on this bool value decide the type of HEAP(HEAP32/HEAPU32).