Avoid using RELOCATABLE by default when building with MAIN_MODULE #16507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
main_module_static
branch
from
235c12b to
9ba8a7e
Compare
sbc100
force-pushed
the
main_module_static
branch
from
9ba8a7e to
b89c7af
Compare
By building main module as non-relocatable we can improve the code size and performance of the main module. There is no good reason to build the main module as relocatable, only the side module really need this. One downside is that this reduces our coverage of the `RELOCATABLE` option to just a few isolated test cases. I wonder if we should consider removing this option unless there are other compelling use cases? This change depends and llvm-side change: https://reviews.llvm.org/D91577
sbc100
force-pushed
the
main_module_static
branch
from
b89c7af to
6308498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By building main module as non-relocatable we can improve the code size
and performance of the main module. There is no good reason to build
the main module as relocatable, only the side module really need this.
One downside is that this reduces our coverage of the
RELOCATABLEoption to just a few isolated test cases. I wonder if we should consider
removing this option unless there are other compelling use cases?
This change depends and llvm-side change: https://reviews.llvm.org/D91577