embind: Add support for std::nullptr_t
#18661
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the first character in the signature represents the return type, in this case |
brendandahl
requested changes
Feb 9, 2023
| @@ -74,6 +75,10 @@ val emval_test_passthrough(val v) { | |||
| void emval_test_return_void() { | |||
| } | |||
|
|
|||
| std::nullptr_t emval_test_return_nullptr_t() { | |||
There was a problem hiding this comment.
Why would a function have a return type of std::nullptr_t. I've seen it used for overloading with parameters but not this?
| @@ -675,6 +675,23 @@ var LibraryEmbind = { | |||
| return this['fromWireType']({{{ makeGetValue('pointer', '0', 'i32') }}}); | |||
| }, | |||
|
|
|||
| _embind_register_std_nullptr_t__sig: 'vpppDn', | |||
| 'fromWireType': function (value) { | ||
| return null; | ||
| }, | ||
| 'toWireType': function (destructors, value) { |
There was a problem hiding this comment.
I don't think null is a valid wasm type. This should probably be 0.
| @@ -74,6 +75,10 @@ val emval_test_passthrough(val v) { | |||
| void emval_test_return_void() { | |||
| } | |||
|
|
|||
| std::nullptr_t emval_test_return_nullptr_t() { | |||
There was a problem hiding this comment.
I also don't see this function bound anywhere. e.g. look at how emval_test_not works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says, this adds support for
std::nullptr_ttypes to the Embind. This came up when bootstrapping a pre-existing binding generator test suite to work with Embind target.Used the sig
vpppDnwhereDnis the Itanium C++ mangled encoding, but not really sure about the rest of the letters, and couldn't really find any documentation regarding how these signatures mean. Is this documented anywhere?