Add a changelog note about Audio Worklets [NFC] [ci skip] #18702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Feb 10, 2023
| @@ -20,6 +20,7 @@ See docs/process.md for more on how version tagging works. | |||
|
|
|||
| 3.1.32 (in development) | |||
| ----------------------- | |||
| - Add support for Audio Worklets. (#16449) | |||
There was a problem hiding this comment.
How about "Add initial support for..".. also should we warn that this is still experimental? (I didn't review the change much so I'm not sure how complete it is).
There was a problem hiding this comment.
(By warning i mean at compile time with diagnostics.warning like we do for wasm64)
There was a problem hiding this comment.
I think it is complete. It was on a branch for a long time, and tested by multiple people there, and only landed after it looked good to them all. So it's a new feature but I wouldn't call it experimental or wip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fairly major feature, seems worth a mention.)