Avoid defining Module in shell_minimal.js. NFC
#22298
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead we can just always use the same technique to define `Module` in `shell_minimal.js`, regardless of the target environment. This simplifies the code and reduces code size.
kripken
approved these changes
Jul 31, 2024
juj
reviewed
Aug 1, 2024
| @@ -28,9 +27,6 @@ var Module = | |||
| // Otherwise do a good old typeof check. | |||
| typeof {{{ EXPORT_NAME }}} != 'undefined' ? {{{ EXPORT_NAME }}} : {}; | |||
| #endif | |||
|
|
|||
| #else | |||
| var Module = {{{ EXPORT_NAME }}}; | |||
There was a problem hiding this comment.
It looks like this reduces code size only for users who do not need to define Module in .html file at all. (if user does need to define Module in .html, then the original var Module = {{{ EXPORT_NAME }}}; definition would be shorter.
Although I think that is ok.
It may read a bit simpler to further condense the code to
#elif SUPPORTS_GLOBALTHIS
var Module = globalThis.{{{ EXPORT_NAME }}} || {};
#else
var Module = typeof {{{ EXPORT_NAME }}} != 'undefined' ? {{{ EXPORT_NAME }}} : {};
#endifbut works either way.
juj
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we can just always use the same technique to define
Moduleinshell_minimal.js, regardless of the target environment.This simplifies the code and reduces code size.