Use a separate build directory for each port #23961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building them simultaneously with Ninja. Split out from emscripten-core#23924
sbc100
reviewed
Mar 20, 2025
sbc100
reviewed
Mar 20, 2025
tools/ports/__init__.py
Outdated
| @@ -233,7 +237,7 @@ def erase(): | |||
|
|
|||
| @staticmethod | |||
| def get_build_dir(): | |||
| return system_libs.get_build_dir() | |||
| return os.path.join(system_libs.get_build_dir(), 'ports') | |||
There was a problem hiding this comment.
Is this needed? I guess its nice to have system libs and ports cleanly separated maybe?
There was a problem hiding this comment.
No, it's not needed. My original version didn't have it but you suggested it in #23924 (comment) (I think I'd kind of prefer not having it).
There was a problem hiding this comment.
I don't feel strongly. lgtm either way.
sbc100
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building them simultaneously with Ninja.
Split out from #23924